[Dune-devel] On moving vtk writer into psurface folder

[Xiaoxue Gong]

Sure, let's chat tomorrow at 10:00 German time.
Xiaoxue


On Wed, Aug 21, 2013 at 8:09 AM, Oliver Sander
<sander at igpm.rwth-aachen.de>wrote:

> Hi Xiaoxue,
> for a first iteration this is good.  You still copy too much stuff, e.g.,
>
> - do not copy shared_ptr.hh, use shared_ptr from the standard library
> instead
> - do not copy nullptr.hh.  If a zero pointer is needed use NULL instead of
> nullptr
>
> There is more code that will not be needed, but finding it will need a
> closer
> look.  So just copy it for now and will have a look later.
>
> Do you have time for a skype chat tomorrow 10:00 German time / 16:00
> Chinese time?
>
> Best,
> Oliver
>
> Am 21.08.2013 12:01, schrieb Xiaoxue Gong:
>
>> Hi, Oliver. I have moved the vtuIO.h, vtuIOtest.h and other related into
>> the psurface folder. The related files moved into psurface folder is:
>> common files:
>> exceptions.hh  indent.hh nullptr.hh shared_ptr.hh typetraits.hh
>> grid files:dune/grid/io/file/vtk/
>> b64enc.hh  common.hh  dataarraywriter.hh  streams.hh   vtuwriter.hh
>> Some changes are made on these file at the same time:
>> 1.delete geometryType() function and #include <geometry/type.hh> from
>> common.hh
>> 2. add the content of exception.cc into exception.hh
>> 3 change the path of included header files.
>> After adding these files into folder ./dune/ and adding them as source
>> file in Makefile.am(the code is updated to https://git.gitorious.org/~**
>> xiaoxueiris/psurface/psurface_**convert.git<https://git.gitorious.org/~xiaoxueiris/psurface/psurface_convert.git>
>> <https://git.gitorious.org/%**7Exiaoxueiris/psurface/**
>> psurface_convert.git<https://git.gitorious.org/%7Exiaoxueiris/psurface/psurface_convert.git>>),
>> we can compile vtuIO.h in psurface folder.
>>
>> Do you think it is OK to make these changes?
>>
>> Xiaoxue
>>
>>
>>
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20130821/4797f9af/attachment.htm>