[Dune-devel] Interface class for EntitySeed
Oliver Sander
sander at igpm.rwth-aachen.de
Mon Jan 21 15:05:39 CET 2013
I don't know. Since there is no written record of what methods an
EntitySeed
should have, I let the test guide me. And the test passes.
best,
Oliver
Am 21.01.2013 15:00, schrieb Martin Nolte:
> Does this mean that (except for ALUGrid), the EntitySeed does
> currently not work with containers anymore? If so, I would consider
> this a bug (which belongs into the FlySpray).
>
> Best,
>
> Martin
>
> On 01/21/2013 02:24 PM, Oliver Sander wrote:
>>
>>>> Dear Dune,
>>>> you may have noticed that I have added an EntitySeed interface class
>>>> to dune-grid. We use the wrapper/engine concept for almost everything
>>>> we do in the grid interface, but it was missing for EntitySeed.
>>>> This change should go unnoticed for users of the grid interface.
>>>> However, grid implementations may need small changes. I have done
>>>> them for all grids in dune-grid. All tests pass here -- apologies
>>>> if I
>>>> broke anything.
>>> shouldn't we also enforce a copy constructor and assignment operator
>>> in order to be able to store EntiySeeds in containers?
>>>
>>> Best,
>>> Carsten
>> Hi Carsten,
>> I have just added all methods needed to make the test pass. Adding
>> methods
>> to allow containers of EntitySeeds does of course sound reasonable.
>> best,
>> Oliver
>>
>>
>>>
>>>> One exception has been the ALUGrid implementation. There,
>>>> the changes appeared to be a little more invasive, and I didn't
>>>> dare to
>>>> mess with that. Since ALUGrid doesn't use the official GridTraits
>>>> class
>>>> anyway (which forces the use of the interface class), it still returns
>>>> its EntitySeed
>>>> implementation class directly.
>>>> best,
>>>> Oliver
>>> _______________________________________________
>>> Dune-devel mailing list
>>> Dune-devel at dune-project.org
>>> http://lists.dune-project.org/mailman/listinfo/dune-devel
>>
>>
>> _______________________________________________
>> Dune-devel mailing list
>> Dune-devel at dune-project.org
>> http://lists.dune-project.org/mailman/listinfo/dune-devel
>
More information about the Dune-devel
mailing list