[Dune-devel] [Dune-Commit] [Commit] dune-grid - e42e63d: add missing header to Makefile.am to make nightly build happy

[Dedner, Andreas]

As I said in the other mail I did not think of the difference between tar ball and installation - 
I can't remember when I last installed dune...
But in this case I'm not quite sure - we do use some of the dune/grid/test files in other modules
containing a grid implementation and I guess to get that to work correctly these header would have
to be installed? But I'll leave that up to you because as I said, I do not really install dune....
Best
Andreas
________________________________________
From: dune-devel-bounces+a.s.dedner=warwick.ac.uk at dune-project.org [dune-devel-bounces+a.s.dedner=warwick.ac.uk at dune-project.org] on behalf of Markus Blatt [markus at dr-blatt.de]
Sent: 06 July 2013 13:07
To: dune-devel at dune-project.org
Subject: Re: [Dune-devel] [Dune-Commit] [Commit] dune-grid - e42e63d: add missing header to Makefile.am to make nightly build happy

Hi Andreas,

thanks for adding the missing header functions.hh. I removed the
duplicates you added in another commit.

What I am wondering is whether we should put the two headers
function.hh and basicunitcube.hh into noinst_HEADERS instead of
SOURCES.

Cheers,

Markus

On Fri, Jul 05, 2013 at 10:44:53PM +0200, Andreas Dedner wrote:
> New commit, appeared at Fri Jul  5 22:44:53 2013 +0200
> as part of the following ref changes:
>
>     branch refs/heads/master    updated from 4732b1b -> e42e63d
>
> Browsable version: http://cgit.dune-project.org/repositories/dune-grid/commit/?id=e42e63dc1308c8e6d40bcc42f17a8ec04d7e0da6
>
> ======================================================================
>
> commit e42e63dc1308c8e6d40bcc42f17a8ec04d7e0da6
> Author: Andreas Dedner <a.s.dedner at warwick.ac.uk>
> Date:   Fri Jul 5 21:36:09 2013 +0100
>
>     add missing header to Makefile.am to make nightly build happy
>
>  dune/grid/test/Makefile.am | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
>
>
> diff --git a/dune/grid/test/Makefile.am b/dune/grid/test/Makefile.am
> index f9266f5..3fa4921 100644
> --- a/dune/grid/test/Makefile.am
> +++ b/dune/grid/test/Makefile.am
> @@ -194,7 +194,8 @@ test_dgfalu_uggrid_combination_LDADD =            \
>       $(LDADD)
>
>  ## distribution tarball
> -SOURCES = gridcheck.cc staticcheck.hh checkindexset.cc checkgeometryinfather.cc checkintersectionit.cc checkcommunicate.cc checkiterators.cc checktwists.cc check-albertareader.cc basicunitcube.hh checkadaptation.cc checkgeometry.cc checkpartition.cc checkentityseed.cc
> +SOURCES = gridcheck.cc staticcheck.hh checkindexset.cc checkgeometryinfather.cc checkintersectionit.cc checkcommunicate.cc checkiterators.cc checktwists.cc check-albertareader.cc basicunitcube.hh checkadaptation.cc checkgeometry.cc checkpartition.cc checkentityseed.cc basicunitcube.hh functions.hh staticcheck.hh
> +
>
>  # gridcheck not used explicitly, we should still ship it :)
>  EXTRA_DIST = CMakeLists.txt $(SOURCES)
>
> _______________________________________________
> Dune-Commit mailing list
> Dune-Commit at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune-commit
>

--
Do you need more support with DUNE or HPC in general?

Dr. Markus Blatt - HPC-Simulation-Software & Services http://www.dr-blatt.de
Hans-Bunte-Str. 8-10, 69123 Heidelberg, Germany
Tel.: +49 (0) 160 97590858  Fax: +49 (0)322 1108991658

_______________________________________________
Dune-devel mailing list
Dune-devel at dune-project.org
http://lists.dune-project.org/mailman/listinfo/dune-devel