[Dune-devel] [Commit] dune-grid - d705c4a: Deprecate the methods leafView and levelView without template parameter

Oliver Sander sander at igpm.rwth-aachen.de
Sat Nov 30 19:42:30 CET 2013


Dear 2.3 release managers,
at the Aachen meeting we decided that the leafGrid/levelGrid methods should be deprecated
in the 2.3 release.  However, with the recent hassle with GeometryGrid caused by the method
renaming I'd say the decision is up to you.
Cheers,
Oliver

Am 30.11.2013 19:39, schrieb Oliver Sander:
> New commit, appeared at Sat Nov 30 19:39:00 2013 +0100
> as part of the following ref changes:
> 
>     branch refs/heads/master    updated from 275a9b1 -> d705c4a
> 
> Browsable version: http://cgit.dune-project.org/repositories/dune-grid/commit/?id=d705c4a98de5f17a4a94cf06690a4e1d8660ab87
> 
> ======================================================================
> 
> commit d705c4a98de5f17a4a94cf06690a4e1d8660ab87
> Author: Oliver Sander <sander at igpm.rwth-aachen.de>
> Date:   Fri Nov 29 12:18:22 2013 +0100
> 
>     Deprecate the methods leafView and levelView without template parameter
>     
>     Because they have been renamed to leafGridView and levelGridView, respectively.
>     Deprecating the corresponding methods with the PartitionType template parameter
>     currently exceeds my C++ skills.
> 
>  dune/grid/common/grid.hh | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> 
> 
> diff --git a/dune/grid/common/grid.hh b/dune/grid/common/grid.hh
> index 5fb4f29..456ee15 100644
> --- a/dune/grid/common/grid.hh
> +++ b/dune/grid/common/grid.hh
> @@ -623,13 +623,13 @@ namespace Dune {
>      }
>  
>      //! View for a grid level for All_Partition
> -    LevelGridView levelView(int level) const {
> +    LevelGridView levelView(int level) const DUNE_DEPRECATED_MSG("The method levelView has been renamed to levelGridView.") {
>        CHECK_INTERFACE_IMPLEMENTATION((asImp().levelView(level)));
>        return asImp().levelView(level);
>      }
>  
>      //! View for the leaf grid for All_Partition
> -    LeafGridView leafView() const {
> +    LeafGridView leafView() const DUNE_DEPRECATED_MSG("The method leafView has been renamed to leafGridView.") {
>        CHECK_INTERFACE_IMPLEMENTATION((asImp().leafView()));
>        return asImp().leafView();
>      }
> @@ -1040,13 +1040,13 @@ namespace Dune {
>  
>      //! View for a grid level for All_Partition
>      typename Traits::template Partition<All_Partition>::LevelGridView
> -    levelView(int level) const {
> +    levelView(int level) const DUNE_DEPRECATED_MSG("The method levelView has been renamed to levelGridView.") {
>        return asImp().levelGridView( level );
>      }
>  
>      //! View for the leaf grid for All_Partition
>      typename Traits::template Partition<All_Partition>::LeafGridView
> -    leafView() const {
> +    leafView() const DUNE_DEPRECATED_MSG("The method leafView has been renamed to leafGridView.") {
>        return asImp().leafGridView();
>      }
>  
> 
> _______________________________________________
> Dune-Commit mailing list
> Dune-Commit at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune-commit
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 551 bytes
Desc: OpenPGP digital signature
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20131130/02c9907e/attachment.sig>


More information about the Dune-devel mailing list