[Dune-devel] StructuredGridFactory<YaspGrid<dim> >

[Oliver Sander]

Hi Christoph,
I don't quite understand the problem.  Deprecated YaspGrid constructors
doesn't mean we are losing functionality.  For every deprecated constructor
there is a new one that takes the same input data, only in other data types.
How can I reproduce your issue?
Cheers,
Oliver

Am 30.10.2013 14:22, schrieb Christoph Grüninger:
> Hi Dune,
> since the constructor of YaspGrid was deprecated the functions
> createCubeGrid and createSimplexGrid in
> StructuredGridFactory<YaspGrid<dim> > trigger a deprecation warning.
> 
> The problem is that the method signature is the same for YaspGrid and
> other grids like SGrid. This makes the functions usefull despite the
> chosen grid:
> 
> createCubeGrid(const FieldVector<ctype,dimworld>& lowerLeft,
>                const FieldVector<ctype,dimworld>& upperRight,
>                const array<unsigned int,dim>& elements)
> 
> What would be the proper fix?
> a) Change the method signature to match the one from YaspGrid. This
> would imply to drop the lowerLeft because it is only used for
> compatiliby to SGrid.
> b) Stick to the old method and convert the arguments internally
> 
> Keep in mind that SGrid should be dropped in near future but not until
> an integrated grid has all its capabilities.
> 
> Bye
> Christoph
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 551 bytes
Desc: OpenPGP digital signature
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20131030/01fd98fb/attachment.sig>