[Dune-devel] Small Patch for parallel UG

[Oliver Sander]

Hi Christoph,
I had a quick look at the patch.  The 'error that should not occur' that you
mention is an exception stating that a certain feature is not implemented.
With the patch that exception is not thrown anymore, but the feature remains
unimplemented.  Surely you understand that I cannot commit such a patch.
Best,
Oliver

Am 16.09.2013 17:19, schrieb Oliver Sander:
> Hi Christoph,
> I am not saying the patch is bad, but I will not consider patches sent to me
> without any reason given.
> In other words: yes I object to it being committed until I have understood
> what it does precisely.  The parallel UGGrid code is delicate stuff.  If you
> cannot give me a better explanation than "fixes an error that should not occur"
> I need to have a closer look myself first.
> Cheers,
> Oliver
>
> Am 16.09.2013 16:55, schrieb Christoph Grüninger:
>> Hi Oliver,
>> the patch is necessary to run an MFEM code in parallel that works fine with SPgrid. The missing case causes an error that should not occur. But maybe I am missing something and the Patch works for
>> Jizhou only by coincidence.
>>
>> Bye
>> Christoph
>>
>> Am 15.09.2013 19:05, schrieb Oliver Sander:
>>> Well, what is the patch supposed to do?
>>> --
>>> Oliver
>>>
>>> Am 15.09.2013 18:05, schrieb Christoph Grüninger:
>>>> Hi there,
>>>> I got a small UG patch for parallel UG from Jizhou Li and I
>>>> adapted it to the current trunk. As I did not test the patch
>>>> myself, I'd like to ask if anyone objects committing it.
>>>>
>>>> Bye
>>>> Christoph
>>
>
>
> _______________________________________________
> Dune-devel mailing list
> Dune-devel at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune-devel