[Dune-devel] 685fea7 [cleanup] Remove classes GeometryReference and StoreGeometryReference

[Oliver Sander]

Hi Martin,
hmm, interesting.  Of course that header should not be included anymore, but I really
did run the tests before committing.  Can this be Alberta-3.0 only?

And then all of a sudden I see a line

 typedef Dune::Geometry< dim-cd, dim, const Grid, LocalGeometryReference > LocalGeometry;

in the same file.  But LocalGeometryReference is gone, too.  What is the proper way to fix this?

Thanks,
Oliver

Am 14.02.2014 13:49, schrieb Martin Nolte:
> Hi Oli,
> 
> this patch breaks AlbertaGrid (already during configuration of dune-grid):
> 
> libtool: compile:  g++-4.7.3 -std=c++11 -DHAVE_CONFIG_H -I. -I../../.. -I/usr/people/nolte/numerics/master/dune-common -I/usr/people/nolte/numerics/master/dune-common
> -I/usr/people/nolte/numerics/master/dune-geometry -I/usr/people/nolte/numerics/master/dune-geometry -I../../.. -I/usr/people/nolte/numerics/install-gcc-4.7/include
> -I/usr/people/nolte/numerics/install-gcc-4.7/include/alberta -DENABLE_ALBERTA -DALBERTA_DIM=1 -Wall -Winit-self -Wfatal-errors -DNDEBUG -O3 -funroll-loops -ffast-math -fexcess-precision=fast
> -march=corei7 -msse -mfpmath=sse --param inline-unit-growth=700 -MT libalbertagrid_1d_la-indexsets.lo -MD -MP -MF .deps/libalbertagrid_1d_la-indexsets.Tpo -c indexsets.cc -o
> libalbertagrid_1d_la-indexsets.o
> In file included from ../../../dune/grid/albertagrid/indexsets.hh:16:0,
>                  from indexsets.cc:7:
> ../../../dune/grid/albertagrid/gridfamily.hh:16:49: fatal error: dune/grid/common/geometryreference.hh: No such file or directory
> 
> Best,
> 
> Martin
> 
> On 02/14/2014 12:28 PM, Oliver Sander wrote:
>> commit 685fea764bb7c8c9f450ef1627624f4cfc229d3d
>> Author: Oliver Sander <sander at igpm.rwth-aachen.de>
>> Date: Fri, 14 Feb 2014 12:28:26 +0100
>>
>> [cleanup] Remove classes GeometryReference and StoreGeometryReference
>>
>> These were only there for a transitional period.
>>
>> M dune/grid/common/CMakeLists.txt
>> M dune/grid/common/Makefile.am
>> M dune/grid/common/geometry.hh
>> D dune/grid/common/geometryreference.hh
>>
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 534 bytes
Desc: OpenPGP digital signature
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20140214/c2aa64f1/attachment.sig>