[Dune-devel] StoreGeometryReference

[Martin Nolte]

Hi Oli,

yes, removing GeometryReference break AlbertaGrid (and SPGrid, but who cares).

The GeometryReference class was explicitly introduced (by me) to allow 
returning references to geometries actually stored on the grid. For example, 
there are only two local geometries for geometryInFather in AlbertaGrid. Why 
bother to recompute them every time the user asks for them? Notice that this 
does not violate the new lifetime guarantees. The "reference" is valid as long 
as the grid exists.

Actually, the idea of the facade options was to avoid this code duplication in 
the first place. Since my fellow developers voted for deprecation of the 
reference version, I needed a replacement. But I will happily duplicate this 
piece of code into every single grid that wants to return a reference to its 
local geometries. Originally it was an implementation detail of SPGrid anyway.

As a final comment: Since when do we ask such questions merely three hours 
before removing the code?

Best,

Martin



On 02/14/2014 09:09 AM, Oliver Sander wrote:
> Dear Dune team,
> IIRC the GeometryReference class and the corresponding traits class StoreGeometryReference
> were supposed to exist only for a transitional period.  Are there objections to their
> removal now that 2.3 has been released?
> Cheers,
> Oliver
>
>
>
> _______________________________________________
> Dune-devel mailing list
> Dune-devel at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune-devel
>

-- 
Dr. Martin Nolte <nolte at mathematik.uni-freiburg.de>

Universität Freiburg                                   phone: +49-761-203-5630
Abteilung für angewandte Mathematik                    fax:   +49-761-203-5632
Hermann-Herder-Straße 10
79104 Freiburg, Germany