[Dune-devel] [Dune-Commit] [Commit] dune-common - 31625a0: Adjust fmatrixtest to use initializer lists.

[Markus Blatt]

Hi,

On Wed, Oct 08, 2014 at 10:30:46AM +0200, Dominic Kempf wrote:
> New commit, appeared at Wed Oct  8 10:30:46 2014 +0200
> as part of the following ref changes:
> 
>     branch refs/heads/master    updated from 650370a -> 275c824
> 
> Browsable version: http://cgit.dune-project.org/repositories/dune-common/commit/?id=31625a0b94688239c8045c2e6fd689daa91d7872
> 
> ======================================================================
> 
> commit 31625a0b94688239c8045c2e6fd689daa91d7872
> Author: Dominic Kempf <dominic.kempf at iwr.uni-heidelberg.de>
> Date:   Mon Oct 6 14:31:04 2014 +0200
> 
>     Adjust fmatrixtest to use initializer lists.
> 
>  dune/common/test/fmatrixtest.cc | 26 ++++++++++++--------------
>  1 file changed, 12 insertions(+), 14 deletions(-)
> 
> 
> 
> diff --git a/dune/common/test/fmatrixtest.cc b/dune/common/test/fmatrixtest.cc
> index 48e659c..3db6a9a 100644
> --- a/dune/common/test/fmatrixtest.cc
> +++ b/dune/common/test/fmatrixtest.cc
> @@ -8,7 +8,6 @@
>  #define DUNE_ISTL_WITH_CHECKING
>  #endif
>  #include <dune/common/fmatrix.hh>
> -#include <dune/common/fassign.hh>
>  #include <dune/common/classname.hh>
>  #include <iostream>
>  #include <algorithm>
> @@ -452,16 +451,16 @@ void test_ev()
>     * A small, nonzero eigenvalue
>  
>     */
> -  Dune::FieldMatrix<ft,8,8> A;
> -  A <<=
> -    611, 196, -192, 407, -8, -52, -49, 29, Dune::nextRow,
> [...]

actually this is a bit overeager. IMHO even deprecated features should
and need to be tested in addition to the new interface. Otherwise
there is no way that we can be sure about their functionality.

Cheers,

Markus


-- 
Do you need more support with DUNE or HPC in general? 

Dr. Markus Blatt - HPC-Simulation-Software & Services http://www.dr-blatt.de
Hans-Bunte-Str. 8-10, 69123 Heidelberg, Germany
Tel.: +49 (0) 160 97590858
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20141008/dae18235/attachment.sig>