[Dune-devel] [Patch] Less warnings in ALUGrid

Christoph GrĂ¼ninger christoph.grueninger at iws.uni-stuttgart.de
Tue Sep 16 13:25:59 CEST 2014


Hi Andreas, hi Martin,
thanks for applying one of my patches.

> Thanks, will fix apply (although I'm a bit unclear about the second one...)

Maybe Clang's warning message sheds more light on the issue:

> ../../../dune/alugrid/impl/serial/gitter_sti.h:1197:144: warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion]
>                                                                                                                                 (A&s){ return &s?(imbue(s.getloc()),s):s;}
>                                                                                                                                        ~~~~~~  ^
> ../../../dune/alugrid/impl/serial/gitter_impl.h:400:8: note: in instantiation of function template specialization 'ALUGrid::Gitter::GhostChildrenInfo::write<std::basic_ostream<char> >' requested here
>     os.write(sr!=p);
>        ^

> I'll comment out the noexcept for the moment though.

Find attached a new patch using the DUNE_NOEXCEPT. The macro can be
found in a dune-common feature branch. Once it is merged, the patch can
be applied.

Bye
Christoph

-- 
GDB does hate your application, expresses its contempt through the
design of its command-line interface.   -- Tom Tromey, FOSDEM 2014
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-DUNE_NOEXCEPT-to-calm-Clang-warning-new-returns-.patch
Type: text/x-patch
Size: 3240 bytes
Desc: not available
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20140916/154daad7/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20140916/154daad7/attachment.sig>


More information about the Dune-devel mailing list