[Dune-devel] Some more improvements on YaspGrid (involves Interface changes)
Dominic Kempf
dominic.r.kempf at gmail.com
Mon Sep 29 15:43:41 CEST 2014
Dear Dune,
this seems like the perfect moment to improve Yasp, so I have done a few
more things, that could, given your approval, be merged soon.
- As announced on the meeting I have written a factory for a tensorproduct
YaspGrid which includes code, that I have written some while back, which we
kept handing around here in Heidelberg. It allows to construct coordinate
sequences, that follow a geometric series. You find it in
p/dominic/coordinate-sequences-helper . The code is kind of standalone. I
know the method names are quite debatable. I have no strong opinion there.
Parts of the interface of the factory were seen in the light of the next
feature:
- I have added an implementation of a BackupRestoreFacility for YaspGrids.
It fulfills the interface defined in dune-grid. While implementing I
stumbled upon how to pass the communicator to such factory. See FS1494
<https://dune-project.org/flyspray/index.php?do=details&task_id=1494>. I
would really love this to be clarified. The implementation in
p/dominic/yaspgrid-backuprestore-facility is written as proposed in the
task already.
- While thinking about FS1497
<https://dune-project.org/flyspray/index.php?do=details&task_id=1497> I
realized, that Yasps confusing list of constructors could be greatly
simplified, if the CollectiveCommunication was default-constructible. There
are at the moment 6 constructors, which implement combinations of
sequential/parallel, equidistant/tensorproduct, etc. I have worked out a
proposal with only two constructors: One for equidistant, one for
tensorproduct grids. 4 of the old constructors are backwards-compatible, 2
need deprecation. Please check this commit
<http://cgit.dune-project.org/repositories/dune-grid/commit/?h=p/dominic/yaspgrid-simplified-constructors&id=49f7eee531e6a827cb5bf9732db047e9a012e0bc>
for the details. Please note, that a positive vote on FS1497
<https://dune-project.org/flyspray/index.php?do=details&task_id=1497> is a
prerequisite here.
- Jö's RandomAccessIterators are on the horizon too, of course. But you
already know about that.
Please feel free to tell your opinions,
Dominic
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20140929/e2be72bb/attachment.htm>
More information about the Dune-devel
mailing list