[Dune-devel] [Dune-Commit] [Commit] dune-common - 3824de8: Fix dune_symlink_to_source_tree for cmake 3.1

[Markus Blatt]

Hi,

On Wed, Apr 01, 2015 at 05:59:35PM +0200, Dominic Kempf wrote:
> it
> 1. determines a list of directories to place a symlink in by inspecting the
> source tree for directories that contain a CMakeLists.txt file.
> 2. it checks whether that directory is located inside a build tree that is
> a subdirectory of the build tree
> 3. It creates a symlink in all those directories.
> 

Ok, I get it. Somehow missed the getting the basename of the file.

> I previously globbed for "*" instead of ".*CMakeLists.txt" to get a list of
> directories, but that include the false positives mentioned in the commit
> message.
> 

Two comments though:

1. Not every source director needs to have a CMakeLists.txt (even if
   this is the case for the core modules).
2, What happens in this sitution:

  CMAKE_SOURE_DIR
  |_ CMakeLists.txt
  |__ subdir
     |_CMakeLists.txt

  Wouldn't I get something like this:

  CMAKE_SOURCE_DIR
  |__src_dir (link)
     |__ subdir
  |__subdir (real subdir)
     |__ src_dir

  This might be intended, of course. I am just wondering.

Markus

-- 
Do you need more support with DUNE or HPC in general? 

Dr. Markus Blatt - HPC-Simulation-Software & Services http://www.dr-blatt.de
Hans-Bunte-Str. 8-10, 69123 Heidelberg, Germany
Tel.: +49 (0) 160 97590858
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20150402/b4c4cd23/attachment.sig>