[Dune-devel] [Dune-Bugs] dune-common | Feature/fix mixed precision dense matrix vector interface (#10)

[Christian Engwer]

Hi Robert,

somehow I can't reference you in the gitlab instance...

As you were the original author of the lines in question, I'd be happy
to hear your opinion on commit
https://gitlab.dune-project.org/core/dune-common/commit/522bc0e27178d168b04394ee7e0da75444636269

It seems the old test was never run with range checks enabled as the
expected interface is not fulfilled by std::vector at even more
important ... not be double[N].

We can either fix this by adding a free function vector_size(...)
(or something similar), which is specilized for some classes. Or we
stick to our implicitly defined interface and don't support
std::vector and double[N].

I would refrain from double[N]. What I could live with is std::vector,
but it will require us to check that every type we want to insert
support size(), which was not the case a couple of years ago. I think
there is the other "feature" that you currently could us
FieldMatrix<double,N,1> similar to the FieldVector<double,N>.

Ciao
Christian

On Mon, Dec 07, 2015 at 07:23:00PM +0000, Christian Engwer wrote:
> New comment for Merge Request 10
> 
> https://gitlab.dune-project.org/core/dune-common/merge_requests/10#note_12813
> 
> 
> Christian Engwer
> 
> Any comments? Otherwise I'll merge tomorrow.
> 

> _______________________________________________
> Dune-Bugs mailing list
> Dune-Bugs at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune-bugs
> 
> This mailing list sends out notifications for all issues and merge requests for the DUNE core modules and infrastructure. If you want more fine-grained control about your notifications, unsubscribe from this list, sign up to https://gitlab.dune-project.org and set your notification preferences accordingly.


-- 
Prof. Dr. Christian Engwer 
Institut für Numerische und Angewandte Mathematik
Fachbereich Mathematik und Informatik der Universität Münster
Einsteinstrasse 62
48149 Münster

E-Mail  christian.engwer at uni-muenster.de
Telefon +49 251 83-35067
FAX     +49 251 83-32729