[Dune-devel] [Dune-Commit] [Commit] dune-grid - f6093f1: [GridCheck][Usability] Change error message wording to distinguish from compiler errors

[Christian Engwer]

Actually I liked the old behaviour. Following the compiler pattern allows to (mis-)use the Emacs jump-to-next-error function to navigate through the output of "make check".

Ciao Christian

Am 10. Februar 2015 18:05:46 MEZ, schrieb "Steffen Müthing" <muething at dune-project.org>:
>New commit, appeared at Tue Feb 10 18:05:46 2015 +0100
>as part of the following ref changes:
>
>    branch refs/heads/master    updated from a3c23eb -> fb70aa3
>
>Browsable version:
>http://cgit.dune-project.org/repositories/dune-grid/commit/?id=f6093f10c9704b3346357273a1366a5017b50642
>
>======================================================================
>
>commit f6093f10c9704b3346357273a1366a5017b50642
>Author: Steffen Müthing <muething at dune-project.org>
>Date:   Tue Feb 10 18:01:33 2015 +0100
>
>[GridCheck][Usability] Change error message wording to distinguish from
>compiler errors
>    
> Some strings in the GridCheck contain the sequence "Error:", which (up
>to capitalization) is identical to the marker for error messages in GCC
>    output ("error:").
>    
>    This patch slightly changes that output to "Error!" to simplify
>searching for error messages in the thousands of lines of compiler
>output.
>
> dune/grid/test/gridcheck.hh | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>
>
>diff --git a/dune/grid/test/gridcheck.hh b/dune/grid/test/gridcheck.hh
>index d117bf1..7a9a75c 100644
>--- a/dune/grid/test/gridcheck.hh
>+++ b/dune/grid/test/gridcheck.hh
>@@ -889,7 +889,7 @@ void checkFatherLevel ( Grid &grid )
> 
>             if (f.level() != level-1)
>             {
>-              std::cerr << "Error: father().level()=" << f.level()
>+              std::cerr << "Error! father().level()=" << f.level()
>                     << " for element on level " << level << std::endl;
>               assert(false);
>             }
>@@ -897,7 +897,7 @@ void checkFatherLevel ( Grid &grid )
> #if !DISABLE_DEPRECATED_METHOD_CHECK
>             if (fatherPointer.level() != level-1)
>             {
>-              std::cerr << "Error: father()->level()=" << f->level()
>+              std::cerr << "Error! father()->level()=" << f->level()
>                     << " for element on level " << level << std::endl;
>               assert(false);
>             }
>@@ -920,14 +920,14 @@ void checkFatherLevel ( Grid &grid )
> 
>             if (f.level() != level-1)
>             {
>-              std::cerr << "Error: father().level()=" << f.level()
>+              std::cerr << "Error! father().level()=" << f.level()
><< " for element on level " << level << " with reassigned father
>pointer" << std::endl;
>               assert(false);
>             }
> #if !DISABLE_DEPRECATED_METHOD_CHECK
>             if (fatherPointer->level() != level-1)
>             {
>-              std::cerr << "Error: father()->level()=" << f->level()
>+              std::cerr << "Error! father()->level()=" << f->level()
><< " for element on level " << level << " with reassigned father
>pointer" << std::endl;
>               assert(false);
>             }
>
>_______________________________________________
>Dune-Commit mailing list
>Dune-Commit at dune-project.org
>http://lists.dune-project.org/mailman/listinfo/dune-commit