[Dune-devel] .in-file mechanism with cmake?!
christian.engwer at uni-muenster.de
Wed Jul 15 16:56:13 CEST 2015
My point is that I'm afraid that other people will have adopted this
technique. And thus I suggest a simple workaround.
On Wed, Jul 15, 2015 at 04:49:19PM +0200, Dominic Kempf wrote:
> I am with Christoph here. If such use case exists in your project, add those
> lines on a per-module basis (in your top level CMakeLists.txt). No need
> to add it in every single CMakeLists file you use them with.
> On Wed, Jul 15, 2015 at 4:44 PM, Christian Engwer <
> christian.engwer at uni-muenster.de> wrote:
> > you really hate our users, don't you?
> > On Wed, Jul 15, 2015 at 04:27:04PM +0200, Christoph Grüninger wrote:
> > > Hi Christian,
> > > no, I am against such a hack. All this magic makes it more complicated
> > > to understand the CMake scripts.
> > >
> > > > this is no option, as the module is supposed to work with both
> > > > autotools and cmake.
> > > >
> > > > Remember... we are in the transition period ;-)
> > >
> > > How about using a second ini input file?
> > >
> > > I don't see why we (you) should make complicated workarounds when we can
> > > keep the problem local. Right after the next release you would be able
> > > to get rid of the old file together with Autotools.
> > this would not be complicated at all. Complicated is the stuff that
> > translates opts files to cmake defines.
> > A simpler solution, but without the possibility of deprecation
> > warnings is a command like
> > set_automake_path_variables()
> > which sets the set of path variables and allows to use the
> > substitution in both cases. Sure, the user can add the list of defines
> > in each CMakeLists.txt, but I think this makes the files far less
> > readable.
> > Christian
> > >
> > > Just my 2 cents,
> > > Christoph
> > >
> > > --
> > > A mathematician is a scientist who can figure out anything, except
> > > such simple things as squaring the circle and trisecting an angle.
> > > [Evan Esar (1899-1995), Esar's Comic Dictionary]
> > >
> > > _______________________________________________
> > > Dune-devel mailing list
> > > Dune-devel at dune-project.org
> > > http://lists.dune-project.org/mailman/listinfo/dune-devel
> > --
> > Prof. Dr. Christian Engwer
> > Institut für Numerische und Angewandte Mathematik
> > Fachbereich Mathematik und Informatik der Universität Münster
> > Einsteinstrasse 62
> > 48149 Münster
> > E-Mail christian.engwer at uni-muenster.de
> > Telefon +49 251 83-35067
> > FAX +49 251 83-32729
> > _______________________________________________
> > Dune-devel mailing list
> > Dune-devel at dune-project.org
> > http://lists.dune-project.org/mailman/listinfo/dune-devel
Prof. Dr. Christian Engwer
Institut für Numerische und Angewandte Mathematik
Fachbereich Mathematik und Informatik der Universität Münster
E-Mail christian.engwer at uni-muenster.de
Telefon +49 251 83-35067
FAX +49 251 83-32729
More information about the Dune-devel