[Dune-devel] [Dune-Commit] [Commit] dune-grid - c966253: [Tests] Added parallel grid tests using MPI if available

[Dominic Kempf]

Hey Markus,

You are of course right about the timeouts, it was an oversight by myself.
Fortunately,
the solution is easy. CMake tests have a TIMEOUT property, that takes
precedence over
the timeout settings of the ctest run (which have no timeout if run without
special options).
I propose the following:

We add a TIMEOUT argument to dune_add_test. If MPI_RANKS are specified, we
make
specifying the TIMEOUT mandatory.

On a similar note, I would *LOVE* to set a global upperbound to how much
time a test
may take, because many tests seem to be written with more than the minimal
necessary
problem size or may need splitting.

Best,
Dominic

PS:
BTW, the snippet you are quoting is an old code that I was cherry-picking
and later
porting to dune_add_test. But dune_add_test does basically the same.


On Mon, Nov 2, 2015 at 8:51 PM, Markus Blatt <markus at dr-blatt.de> wrote:

> Hey,
>
> On Sun, Nov 01, 2015 at 05:18:54PM +0100, Dominic Kempf wrote:
> > New commit, appeared at Sun Nov  1 17:18:54 2015 +0100
> > as part of the following ref changes:
> >
> >     branch refs/heads/feature/yaspgrid-testing
>  created as              7e47c04
> >     branch refs/merge-requests/3/head
> created as              7e47c04
> >
> > +
> > +  # Create tests with mpi command and add them to the test target
> > +  foreach(_test ${TESTS_PARALLEL})
> > +    add_test(NAME ${_test}_parallel
> > +      COMMAND ${MPIEXEC} ${MPIEXEC_NUMPROC_FLAG} "2" ${_test})
> > +    add_dependencies(${_test_target} ${_test}_parallel)
> > +  endforeach(_test ${TESTS_PARALLEL})
> > +
>
> Guys, this has to be improved. If you really want to do automatic
> parallel testing, then you need to find a way to stop deadlocked
> tests. Otherwise sooner or later your servers will not be usable
> anymore.
>
> Markus
>
> --
> Join us at the DUNE User Meeting Sept. 28-29, 2015, Heidelberg, Germany
> http://users.dune-project.org/projects/dune-user-meeting-2015/wiki
>
> Dr. Markus Blatt - HPC-Simulation-Software & Services
> http://www.dr-blatt.de
> Hans-Bunte-Str. 8-10, 69123 Heidelberg, Germany
> Tel.: +49 (0) 160 97590858
>
> _______________________________________________
> Dune-devel mailing list
> Dune-devel at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20151103/373367ed/attachment.htm>