[Dune-devel] [Dune-Commit] [Commit] dune-istl - 1e08036: [bugfix][RestartedGMResSolver] signature of method apply was wrong when real_type != double.

[Markus Blatt]

Hi,

On Fri, Oct 09, 2015 at 01:44:53PM +0200, Robert K wrote:
> New commit, appeared at Fri Oct  9 13:44:53 2015 +0200
> as part of the following ref changes:
> 
>     branch refs/heads/master    updated from e8d1638 -> 1e08036
> 
> Browsable version: http://cgit.dune-project.org/repositories/dune-istl/commit/?id=1e08036fd55f104e5b18490f480b012ed94382ca
> 
> ======================================================================
> 
> commit 1e08036fd55f104e5b18490f480b012ed94382ca
> Author: Robert K <robertk at posteo.org>
> Date:   Fri Oct 9 13:40:48 2015 +0200
> 
>     [bugfix][RestartedGMResSolver] signature of method apply was wrong when real_type != double.
> 
>  dune/istl/solvers.hh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> 
> diff --git a/dune/istl/solvers.hh b/dune/istl/solvers.hh
> index a3dd92e..f2aa71b 100644
> --- a/dune/istl/solvers.hh
> +++ b/dune/istl/solvers.hh
> @@ -1195,7 +1195,7 @@ namespace Dune {
>  
>         \copydoc InverseOperator::apply(X&,Y&,double,InverseOperatorResult&)
>       */
> -    virtual void apply (X& x, Y& b, real_type reduction, InverseOperatorResult& res)
> +    virtual void apply (X& x, Y& b, double reduction, InverseOperatorResult& res)

I have trouble comprehending what is fixed here. Using real_type
should actually work, but I might be missing something. Would you please
add a test where this failed to our test suite? Then I hopefully get
the problem. Thanks.

Cheers,

Markus

-- 
Dr. Markus Blatt - HPC-Simulation-Software & Services http://www.dr-blatt.de
Hans-Bunte-Str. 8-10, 69123 Heidelberg, Germany
Tel.: +49 (0) 160 97590858
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20151009/d5568009/attachment.sig>