[Dune-devel] Derive Dune::Exception from std::exception

[Christian Engwer]

OK, I'll have a look. We should move the what() to the lib, this would
be the cleaner version. Having a virtual function, which needs to be
inlined is kind of "broken by design".

Christian

On Thu, Oct 29, 2015 at 07:45:44AM +0100, Christoph Grüninger wrote:
> Hi Christian,
> thanks for having a look at my branch.
> 
> Your removal of inline breaks compilation of some common tests, e.g.:
> 
> > Scanning dependencies of target stringutilitytest
> > [ 75%] Building CXX object dune/common/test/CMakeFiles/stringutilitytest.dir/stringutilitytest.cc.o
> > [100%] Linking CXX executable stringutilitytest
> > ../../../lib/libdunecommon.a(exceptions.cc.o): In function `Dune::Exception::what() const':
> > /temp/gruenich/dune/complete/dune-common/dune/common/exceptions.cc:(.text+0x0): multiple definition of `Dune::Exception::what() const'
> > CMakeFiles/stringutilitytest.dir/stringutilitytest.cc.o:/temp/gruenich/dune/complete/dune-common/dune/common/test/stringutilitytest.cc:(.text+0x0): first defined here
> > ../../../lib/libdunecommon.a(exceptions.cc.o):(.rodata+0x50): multiple definition of `typeinfo for Dune::Exception'
> > CMakeFiles/stringutilitytest.dir/stringutilitytest.cc.o:(.rodata+0x50): first defined here
> > ../../../lib/libdunecommon.a(exceptions.cc.o):(.rodata+0x30): multiple definition of `typeinfo name for Dune::Exception'
> > CMakeFiles/stringutilitytest.dir/stringutilitytest.cc.o:(.rodata+0x30): first defined here
> > ../../../lib/libdunecommon.a(exceptions.cc.o):(.rodata+0x0): multiple definition of `vtable for Dune::Exception'
> > CMakeFiles/stringutilitytest.dir/stringutilitytest.cc.o:(.rodata+0x0): first defined here
> 
> Bye
> Christoph
> 
> -- 
> A mathematician is a scientist who can figure out anything, except
> such simple things as squaring the circle and trisecting an angle.
> [Evan Esar (1899-1995), Esar's Comic Dictionary]
> 



> _______________________________________________
> Dune-devel mailing list
> Dune-devel at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune-devel


-- 
Prof. Dr. Christian Engwer 
Institut für Numerische und Angewandte Mathematik
Fachbereich Mathematik und Informatik der Universität Münster
Einsteinstrasse 62
48149 Münster

E-Mail  christian.engwer at uni-muenster.de
Telefon +49 251 83-35067
FAX     +49 251 83-32729