[Dune-devel] [PATCH 0/2] Junior job related to the grid backend based on p4est

[Michaël Sghaier]

Hi,

this is my patch for the junior job proposed by Oliver, regarding the p4est project.
Actually, this is my first patch on a mailing list, so I'm not so sure about the format I used.
I did this with "git format-patch --cover-letter -2" and then "git send-email --to=dune-devel at dune-project.org" which has resulted in 3 mails, is that ok?

Concerning the job itself, it was :

1) Create new Dune module 'dune-p4estgrid' using the duneproject tool

2) Copy the IdentityGrid grid manager from dune-grid to the new module
   Make sure it passes the test suite.

3) Rename all occurrences of 'IdentityGrid' to 'P4estGrid'

So I first used duneproject and specified dune-common and dune-geometry as dependencies (same as dune-grid), then I copied /dune-grid/dune/grid/identitiygrid.hh and /dune-grid/dune/grid/identitygrid/ to dune-p4estgrid/dune/p4estgrid/ (I assumed it was the meaning of "the IdentityGrid grid manager").

Finally, I renamed all occurrences of "identitygrid" to "p4estgrid" (for each case sensitive case).

I'm not so sure about "Make sure it passes the test suite". What is exactly the test suite? I didn't find anything about it in the grid-howto.pdf nor in the buildsystem.pdf nor in the Doxygen documentation.
I just read about "headercheck" in the buildsystem.pdf document so I set the flag ENABLE_HEADERCHECK at 1 in dune-p4estgrid/CMakeLists.txt and ran the headercheck with dunecontrol. Is that correct?

I'm looking forward to your reviews.

Kind regards,
Michaël

PS:
I tried to sign-in in the GitLab with my Github account and got this error:
"Your account is blocked. Retry when an admin has unblocked it."
Can you do something about it?

Michaël Sghaier (2):
  Skeleton for the project of a grid backend based on the p4est library
  Add the IdentityGrid grid manager and rename all IdentityGrid to
    P4estGrid