[Dune-devel] Accidental push to dune-common:master

[Steffen Müthing]

Hi Christoph,

can we maybe try it? Creating and merging a MR is a bit more work (clicking the link given
by Git when pushing the branch, and then clicking Submit + Auto-Merge), but I think it really
helps with avoiding accidental pushes of broken stuff (which happens to all of us).

See it like this: If you push a trivial fix to master, you should really compile and run the tests
locally anyway. Now, you just outsource that job to the CI system.

Steffen

> Am 18.09.2017 um 18:31 schrieb Christoph Grüninger <foss at grueninger.de>:
> 
> Hi Steffen,
> sorry for my late reply, but I would like to be able performing direct pushes to master. Changing trivial things for every module becomes annoying with branches. Given that some of the house-keeping is done by me, not everybody might feel my pain.
> 
> Bye,
> Christoph
> 
>> Am 18.09.2017 um 15:34 schrieb Steffen Müthing <steffen.muething at iwr.uni-heidelberg.de>:
>> 
>> Hi everyone,
>> 
>> judging by the lack of enraged outcries, I think we should try this. I’ll disable pushing
>> to master, and we’ll see how it goes. If it turns out to be a real nuisance, we can always
>> go back.
>> 
>> Steffen
>> 
>> 
>>> Am 14.09.2017 um 21:44 schrieb Christian Engwer <christian.engwer at uni-muenster.de>:
>>> 
>>> Dear all,
>>> 
>>>> I just accidentally pushed what was supposed to be a merge request directly to the
>>>> master branch of dune-common (sorry about that…).
>>>> 
>>>> But that got me thinking: Should we just disable direct pushes to the master branch
>>>> in the core modules?
>>> 
>>> we discussed this a while ago and at that time the response was that
>>> several people where afraid of the extra effort to push mini changes
>>> (like fixing a doc typo) via a merge request. On the other hand I have
>>> the impression that everybody got accustomed to the new workflow and
>>> people are also opening merge requests for such small changes. Thus I
>>> have the impression that time is ready to just disable direct pushes.
>>> 
>>> Christian
>> 
>> _______________________________________________
>> Dune-devel mailing list
>> Dune-devel at lists.dune-project.org
>> http://lists.dune-project.org/mailman/listinfo/dune-devel
> 
> _______________________________________________
> Dune-devel mailing list
> Dune-devel at lists.dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune-devel
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: Message signed with OpenPGP
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20170919/6eb11b4b/attachment.sig>