[Dune-devel] convert `enum` to `static const int`

Ansgar Burchardt Ansgar.Burchardt at tu-dresden.de
Wed Sep 20 13:58:41 CEST 2017


Hi,

it looks like GCC has new warnings:

    ../dune/grid/test/checkintersectionit.hh:599:58: warning:
    comparison between ‘enum Dune::Grid<[...]>::<unnamed>’
    and ‘enum Dune::Grid<[...]>::<unnamed>’ [-Wenum-compare]

for the expression

    GridType::dimension == GridType::dimensionworld

Is there any downside to changing every constant that is currently a
`enum` to a `static const int`?  (Minus deciding on the signedness, but
that is unrelated to the `enum` -> `static const` conversion.)

Ansgar
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 6519 bytes
Desc: not available
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20170920/70ae38ce/attachment.bin>


More information about the Dune-devel mailing list