<div dir="ltr">Hi, Markus,<br><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Aug 5, 2013 at 3:21 AM, Markus Blatt <span dir="ltr"><<a href="mailto:markus@dr-blatt.de" target="_blank">markus@dr-blatt.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">HI xiaoxue,<br>
<div class="im"><br>
<br>
On Sat, Aug 03, 2013 at 01:02:22PM -0400, Xiaoxue Gong wrote:<br>
> Last week I modified the vtu and hdf5 io code according to Markus' guide<br>
> to make it looks better:<br>
> 1. Changed the method and class names according to Camel-case to adhere to<br>
> dune guidelines.<br>
> 2. Remove all the indent and trailing white space in the code.<br>
> 3. Put all the functions that deals with io into one class(vtkPWriter).<br>
> 4.Extend the template parameters of vtkPWriter. It could only deal with 2<br>
> dimensional psurface and float. Not it support 1 dimensional psurface, and<br>
> the float.<br>
<br>
</div>Are you sure that you pushed all of your changes? I do not see a way<br>
of using a PSurface with dimension 1. Could you explain how to<br>
read/write such a surface with the current code?<br></blockquote><div> Sorry, I failed to push the changes to the file. I pushed the new change to the repository just now.<br><div> It is added into vtuIO.h.<br></div>
<br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class="im"><br>
> 5. Use command line parameters to get the input filename.<br>
> The modified code have been pushed to git://<br>
> <a href="http://gitorious.org/gcos/psurface-convert.git" target="_blank">gitorious.org/gcos/psurface-convert.git</a><br>
><br>
> Issues that I have not solved includes:<br>
> + Moving headers<br>
> "Some your headers seem to be usable by other programs. E.g. one might want<br>
> to read xmf files in one's own applications. This headers should be under<br>
> dune and be installed, the cpp file should become part of a library. You<br>
> can see how this is done in dune-common/dune/common. "<br>
> +The include path issue<br>
> What is up with the weired AC_ARG_WITH clauses in <a href="http://configure.ac" target="_blank">configure.ac</a>? I do not<br>
> think that they are needed and doubt that they serve their intended<br>
> purpose.<br>
> +Please try to document your code along (or even before) writing it<br>
> using the doxygen syntax. Most developers (me, too) are not<br>
> disciplined enough to document their code after writing it. In the<br>
> rare occasion the we are and that there is time left, we are often<br>
> having a hard time understanding it ourselves (which is a shame and<br>
> waste of time). I would recommend documenting it properly _now_.<br>
><br>
> I will address these issues in the next week and then move to task #2:<br>
> "start with input from a gmsh file and construct a PSurface object from a<br>
> given domain surface."<br>
<br>
</div>Does that mean that reading a psurface from HDF5 is already<br>
implemented? If not then please first finish 3.<br></blockquote><div> I have not implemented reading a psurface from HDF5 yet. OK, I will finish 3 first. <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class="im"><br>
> In order to to that I need a gmsh file to start with. Maybe I should first<br>
> write functions that can write PSurface object into gmsh file. The file<br>
> should contain all information I need to build psurface.<br>
<br>
</div>No you should not. I do not think that there is any need to be able to<br>
write a PSurface object to GMsh format. You can use gmsh itself to<br>
create a parameterized surface.<br>
<br>
Regards,<br>
Markus<br>
<span class=""><font color="#888888"><br>
--<br>
Do you need more support with DUNE or HPC in general?<br>
<br>
Dr. Markus Blatt - HPC-Simulation-Software & Services <a href="http://www.dr-blatt.de" target="_blank">http://www.dr-blatt.de</a><br>
Hans-Bunte-Str. 8-10, 69123 Heidelberg, Germany<br>
Tel.: <a href="tel:%2B49%20%280%29%20160%2097590858" value="+4916097590858">+49 (0) 160 97590858</a> Fax: +49 (0)322 1108991658<br>
<br>
_______________________________________________<br>
Dune-devel mailing list<br>
<a href="mailto:Dune-devel@dune-project.org">Dune-devel@dune-project.org</a><br>
<a href="http://lists.dune-project.org/mailman/listinfo/dune-devel" target="_blank">http://lists.dune-project.org/mailman/listinfo/dune-devel</a><br>
</font></span></blockquote></div><br></div></div></div>