<div dir="ltr"><div><div><div><div>Okay, I agree I was overeager. I guess this was the result of the combination of<br></div>a) my discontent with the status quo of those tests breaking the dune-common tests on cmake (although this issue could be solved in similar fashion as the debugallocatortests I fixed afterwards)<br></div>b) my surprise about the existence of such code and the fact, that it was not used a single time outside the unit tests testing that very same code. (Would have expected it in istl tests)<br></div>But if you want to stick with it, I will revert the removal of the tests.<br><br></div>Dominic<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 13, 2014 at 4:51 PM, Christoph Grüninger <span dir="ltr"><<a href="mailto:christoph.grueninger@iws.uni-stuttgart.de" target="_blank">christoph.grueninger@iws.uni-stuttgart.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Markus,<br>
hi Dominic,<br>
<br>
we can reintroduce the test code and surround it by<br>
a DISABLE_DEPRECATED_METHOD_<u></u>CHECK. If this macro is set<br>
we can return exit code 77.<br>
<br>
Would this be acceptable for Dune 2.4?<br>
<br>
Bye<br>
Christoph<div><div class="h5"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
<br>
On Wed, Oct 08, 2014 at 10:30:46AM +0200, Dominic Kempf wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
New commit, appeared at Wed Oct 8 10:30:46 2014 +0200<br>
as part of the following ref changes:<br>
<br>
branch refs/heads/master updated from 650370a -> 275c824<br>
<br>
Browsable version: <a href="http://cgit.dune-project.org/repositories/dune-common/commit/?id=31625a0b94688239c8045c2e6fd689daa91d7872" target="_blank">http://cgit.dune-project.org/<u></u>repositories/dune-common/<u></u>commit/?id=<u></u>31625a0b94688239c8045c2e6fd689<u></u>daa91d7872</a><br>
<br>
==============================<u></u>==============================<u></u>==========<br>
<br>
commit 31625a0b94688239c8045c2e6fd689<u></u>daa91d7872<br>
Author: Dominic Kempf <<a href="mailto:dominic.kempf@iwr.uni-heidelberg.de" target="_blank">dominic.kempf@iwr.uni-<u></u>heidelberg.de</a>><br>
Date: Mon Oct 6 14:31:04 2014 +0200<br>
<br>
Adjust fmatrixtest to use initializer lists.<br>
<br>
dune/common/test/fmatrixtest.<u></u>cc | 26 ++++++++++++--------------<br>
1 file changed, 12 insertions(+), 14 deletions(-)<br>
<br>
<br>
<br>
diff --git a/dune/common/test/<u></u>fmatrixtest.cc b/dune/common/test/<u></u>fmatrixtest.cc<br>
index 48e659c..3db6a9a 100644<br>
--- a/dune/common/test/<u></u>fmatrixtest.cc<br>
+++ b/dune/common/test/<u></u>fmatrixtest.cc<br>
@@ -8,7 +8,6 @@<br>
#define DUNE_ISTL_WITH_CHECKING<br>
#endif<br>
#include <dune/common/fmatrix.hh><br>
-#include <dune/common/fassign.hh><br>
#include <dune/common/classname.hh><br>
#include <iostream><br>
#include <algorithm><br>
@@ -452,16 +451,16 @@ void test_ev()<br>
* A small, nonzero eigenvalue<br>
*/<br>
- Dune::FieldMatrix<ft,8,8> A;<br>
- A <<=<br>
- 611, 196, -192, 407, -8, -52, -49, 29, Dune::nextRow,<br>
[...]<br>
</blockquote>
<br>
actually this is a bit overeager. IMHO even deprecated features should<br>
and need to be tested in addition to the new interface. Otherwise<br>
there is no way that we can be sure about their functionality.<br>
<br>
Cheers,<br>
<br>
Markus<br>
</blockquote>
<br>
<br>
-- <br></div></div>
Das Kommt darauf an, in welchen Zeiträumen du<br>
rechnest. Für Geologen: ja, in naher Zukunft<br>
[Stefan Seyfried in suse-laptop]<br>
<br>
______________________________<u></u>_________________<br>
Dune-devel mailing list<br>
<a href="mailto:Dune-devel@dune-project.org" target="_blank">Dune-devel@dune-project.org</a><br>
<a href="http://lists.dune-project.org/mailman/listinfo/dune-devel" target="_blank">http://lists.dune-project.org/<u></u>mailman/listinfo/dune-devel</a><br>
</blockquote></div><br></div>