<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<meta content="text/html; charset=UTF-8">
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<p>Hi Christoph, Hi Markus,</p>
<p><br>
</p>
<p>thanks a lot for organizing this first release candidate.</p>
<p><br>
</p>
<p>I tried out my stack for dune-copasi with 5 settings and here is my feedback: </p>
<p><br>
</p>
<p>- Dependencies: common, geometry, grid, uggrid, istl, localfunctions, functions, logging, multidomaingrid, typetree, testtools, pdelab (custom branch).</p>
<p>- MPI is disabled</p>
<p>- <span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content">
<span class="" style="">QuadMath</span></span> is disabled</p>
<p>- Using <span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content">
<span class="" style="">GMP</span></span></p>
<p><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style="">-
<span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content">
<span class="" style="">C++</span></span> Flags: visibility hidden and position independent code</span></span></p>
<p><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style="">- Using python venv for testtools (except on Windows)<br>
</span></span></p>
<p><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style="">- Build type: Release</span></span></p>
<p><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style="">- Every module is installed and its build dir is removed before the next one is processed</span></span>: This ensures that headers are correctly
installed on every single module.<br>
</p>
<p><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style="">- CMake Warnings (same for all systems except Debian):</span></span></p>
<p><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""> - (dev)
<span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content">
<span class="" style="">Warnign</span></span> Policy not set: CMP0087<br>
</span></span></p>
<span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""> -
</span></span><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style="">(dev)
<span class="dt-fm select">Warning</span> at <span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content">
<span class="" style="">cmake/modules/DuneGridMacros.cmake:20: include(<span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style="">Psurface</span></span>)</span></span></span></span></span></span></span></span></span></span></div>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style="">-
CMake Error (same for all systems):</span></span></span></span></span></span> </span>
</span></span></span></span></span><br>
<p></p>
<p> - CMake module does not exist DuneCxaDemangle. (E<span>asy fix both in source and in dune-common</span>, see MR !987)<br>
</p>
<p><br>
</p>
<p>Setup 1:<br>
</p>
<p>- OS: Ubuntu 16.04.7 LTS</p>
<p>- Compiler: GNU <span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content">
<span class="" style="">9.3.0</span></span></p>
<p><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style="">-
Using dune as shared lib</span></span></span></span></span><br>
</span></span></p>
<span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""></span></span></span></span></span></span></span></span></span></span><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""></span></span><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""></span></span>
<div></div>
<div>
<div class="js-check-step-line CheckStep-line d-flex log-line-plain"></div>
</div>
- C++ Warnings:</div>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
- UGGrid: <br>
<p><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""></span></span></span></span></p>
<div>
<div class="js-check-step-line CheckStep-line d-flex log-line-plain"></div>
</div>
<div>
<div class="js-check-step-line CheckStep-line d-flex log-line-plain"><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style="">
- /tmp/setup-dune/dune-uggrid/dune/uggrid/gm/ugio.cc:3360:39</span></span>: warning: argument 1 value ‘18446744073709551614’ exceeds maximum object size 9223372036854775807 [-Walloc-size-larger-than=]</span></span></div>
</div>
<div>
<div class="js-check-step-line CheckStep-line d-flex log-line-plain"></div>
</div>
<div>
<div class="js-check-step-line CheckStep-line d-flex log-line-plain"> - <span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content">
<span class="" style="">/tmp/setup-dune/dune-uggrid/dune/uggrid/gm/er.cc:1664:50: warning: iteration 4 invokes undefined behavior [-Waggressive-loop-optimizations]
</span></span></div>
</div>
<div>
<div class="js-check-step-line CheckStep-line d-flex log-line-plain"></div>
</div>
- <span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content">
<span class="" style="">/tmp/setup-dune/dune-uggrid/dune/uggrid/gm/er.cc:1666:40: warning: iteration 4 invokes undefined behavior [-Waggressive-loop-optimizations]
</span></span>
<div></div>
<div>
<div class="js-check-step-line CheckStep-line d-flex log-line-plain"></div>
</div>
<p> - <span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content">
<span class="" style="">/tmp/setup-dune/dune-uggrid/dune/uggrid/gm/ugio.cc:3360:39:
<span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content">
<span class="" style="">warning: argument 1 value ‘18446744073709551614’ exceeds maximum object size 9223372036854775807 [-Walloc-size-larger-than=]</span></span><br>
</span></span></p>
<p><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><br>
</span></span></p>
<p><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span>Setup 2:</span><br>
</span></span></p>
<p><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""></span></span>- OS: MacOSX 10.15.7</p>
<p>- Compiler: <span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content">
<span class="" style="">AppleClang 12.0.0.12000032</span></span></p>
<p><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style="">- Using dune as shared lib<br>
</span></span></p>
<p><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span>- C++ Warnings:</span><br>
</span></span></p>
<div> - UGGrid: <br>
<p><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""></span></span></span></span></p>
<div>
<div class="js-check-step-line CheckStep-line d-flex log-line-plain"></div>
</div>
<span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""> -
<span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content">
<span class="" style="">13 warnings at <span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content">
<span class="" style="">/tmp/setup-dune/dune-uggrid/dune/uggrid/domain/std_domain.cc</span></span>: array index XX is past the end of the array (which contains YY element) [-Warray-bounds]</span></span></span></span></span></span></div>
<div><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span>
- Source lines: 1886:25-2086:5-2088:5-2089:5-2099:25-2099:51-2100:17-2108:25-2108:51-2108:61-2136:29-2136:60-2137:21</span><br>
</span></span></span></span></span></span></div>
- <span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content">
<span class="" style="">/tmp/setup-dune/dune-uggrid/dune/uggrid/gm/ugm.cc:191:11: warning: result of comparison of constant 32 with expression of type 'UG::D2::GM_OBJECTS' is always false [-Wtautological-constant-out-of-range-compare]</span></span></div>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<br>
<span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""></span></span></div>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
Setup 3 and 4:</div>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
- OS: <span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content">
<span class="" style="">Microsoft Windows Server 2019</span></span> 10.0.17763</div>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span>- Compiler:
<span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content">
<span class="" style="">mingw-w64-x86_64-gcc</span></span> / GNU <span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content">
<span class="" style="">10.3.0</span></span> and <span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content">
<span class="" style=""><span><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style="">mingw-w64-i686-gc</span></span><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""></span></span>c
/ GNU <span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content">
<span class="" style="">10.3.0 (this is for 32bit Windows)</span></span></span></span></span><br>
</span></span></span></div>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style="">- Using dune as static lib</span></span><br>
</span></span></span></div>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span>- C++ Warnings:</span></span></span><br>
</div>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<span> - UGGrid: Same warnings as for Ubuntu</span><br>
</div>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
- <span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content">
<span class="" style="">CMake Warning at C:/smelibs/share/dune/cmake/modules/DuneSymlinkOrCopy.cmake:196 (message):
<span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content">
<span class="" style="">Your module wanted to create symlinks, but you cannot do that on your
</span></span><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style="">platform.</span></span></span></span>
<div></div>
</div>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<p><br>
</p>
<p><span>Setup 5:</span></p>
<p><span>- Base Docker Image: <span>docker/ci/debian:10</span><br>
</span></p>
<p><span>- Compiler: GNU 8.3.0<br>
</span></p>
<p><span><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span><span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style="">- Using dune as
shared lib</span></span></span></span></span><br>
</span></p>
<p><span></span></p>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<span class="CheckStep-line-content d-inline-block flex-auto ml-3 js-check-line-content"><span class="" style=""><span>- C++ Warnings:</span></span></span><br>
</div>
<span> - UGGrid: Same warnings as for Ubuntu</span><br>
<p></p>
<p><span><br>
</span></p>
<p><span></span><br>
</p>
<p></p>
<span></span>
<p></p>
<p>So I have same remarks as Simon regarding uggrid. But in my experience uggrid has always being a source of many compiler warnings and is not particular to this release.</p>
<p><br>
</p>
<p>Best Regards and Thanks!</p>
<p>Santiago<br>
</p>
<p></p>
<p><br>
</p>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> Dune-devel <dune-devel-bounces@lists.dune-project.org> on behalf of Christoph Grüninger <foss@grueninger.de><br>
<b>Sent:</b> Thursday, August 5, 2021 12:26:06 AM<br>
<b>To:</b> dune-devel@lists.dune-project.org<br>
<b>Subject:</b> Re: [Dune-devel] First candidate for upcoming release 2.8.0 available for testing</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt">
<div class="PlainText">Hi Simon,<br>
thanks for testing and providing feedback!<br>
<br>
> cmake warnings:<br>
> - Policy CMP0087 is not set (I think we should fix this in the next<br>
> release)<br>
<br>
CMP0087 was introduced in CMake 3.14, we require 3.13. I have not found<br>
a way to silence this warning, beside explicitly setting the policy in<br>
every module's root CMakeLists.txt.<br>
<br>
> - WARNING: could not find module 'dune-python', [...] 'dune-python' is<br>
> suggested by dune-foamgrid<br>
<br>
Should be fixed within dune-foamgrid. Not sure whether it is enough to<br>
just drop the suggestion. Maybe the Python code has to be adjusted, too.<br>
<br>
> - dune-common/dune/common/reservedvector.hh:70:5: note: variable<br>
> tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying<br>
> without (this I get a lot, but don't know what to do about it)<br>
<br>
GCC gives up on tracking. You can increase the buffer size by passing<br>
--param=max-vartrack-size= with the right number. This will increase the<br>
compile time and memory consumption.<br>
Or we could simplify our code here, maybe with never language features.<br>
Not sure if it is worth the effort or even possible.<br>
<br>
> So, maybe we should fix the onedgrid errors that occur with -std=c++20.<br>
> It is easy to fix. There just the template parameters on the constructor<br>
> and destructor must be removed.<br>
<br>
Can you please create an MR?<br>
<br>
> Most of the warnings come from the dune-uggrid module. There is still<br>
> a lot of cleanup necessary. This is not a quick fix.<br>
<br>
Low hanging fruits were already collected. Oliver usually welcomes any<br>
clean-up work for UG.<br>
<br>
Bye<br>
Christoph<br>
<br>
_______________________________________________<br>
Dune-devel mailing list<br>
Dune-devel@lists.dune-project.org<br>
<a href="https://lists.dune-project.org/mailman/listinfo/dune-devel" id="LPlnk695264" previewremoved="true">https://lists.dune-project.org/mailman/listinfo/dune-devel</a></div>
</span></font></div>
</body>
</html>