<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="elementToProof">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<div><br>
<blockquote class="userQuote" style="border-left: 3px solid rgb(200, 200, 200); padding-left: 1ex; margin-left: 0.8ex; color: rgb(102, 102, 102);" itemscope="" itemtype="https://schemas.microsoft.com/QuotedText">
Alternative: we find a way to manually run downstream pipelines, maybe<br>
not only in dune-common but also in other core modules. Maybe we can run<br>
these jobs automatically if a branch is merged into the master branch.<br>
This is the important situation to test everything, we might not want to<br>
test all downstream modules for each uploaded commit. This needs some<br>
improvement of the gitlab-ci file.</blockquote>
<br>
</div>
</div>
Hi.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="elementToProof">
I would say that we shouldn't run the whole test suite for every commit - ruinning the CI<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="elementToProof">
for every single commit is questionable anyway from a energy perspective especially for 'Draft' MRs.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="elementToProof">
Not allowing merges into master if downstream module testing fails might be worth exploring.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="elementToProof">
It can of course slow down development if a downstream module is failing for some unrelated reason though.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="elementToProof">
Best<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="elementToProof">
Andreas<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Dune-devel <dune-devel-bounces@lists.dune-project.org> on behalf of Simon Praetorius <simon.praetorius@tu-dresden.de><br>
<b>Sent:</b> 25 November 2022 08:52<br>
<b>To:</b> dune-devel@lists.dune-project.org <dune-devel@lists.dune-project.org><br>
<b>Subject:</b> [Dune-devel] WG: Re: Nightly tests still using Ubuntu 18.04</font>
<div> </div>
</div>
<div>
<p dir="ltr" style="margin-top:0; margin-bottom:0">Sorry. My answer was sent only to Christoph, yesterday.
</p>
<br>
<br>
---- Originalnachricht ----<br>
Betreff: Re: [Dune-devel] Nightly tests still using Ubuntu 18.04<br>
Gesendet: 24.11.2022 23:55<br>
Von: Simon Praetorius <simon.praetorius@tu-dresden.de><br>
An: Christoph Grüninger <foss@grueninger.de><br>
Cc: <br>
<br>
Hi Christoph,<br>
<br>
The nightly tests are not yet aligned with the compiler version changes <br>
in the core modules. This will be done.<br>
<br>
The failing pipeline is due to an (already fixed) typo in the recent <br>
change of FindSuiteSparse.cmake. I have overlooked the position of an <br>
underscore.<br>
<br>
We should, however, update our gitlabci in dune-common regarding the <br>
downstream test. Suggestions:<br>
<br>
- We remove the flag "allow_failure". This has the effect, that e.g. <br>
"merge on passed pipeline" does not merge in case of downstream failures<br>
- We increase the list of tested downstream modules to the same list as <br>
in the nightly tests, maybe with anything outside the core modules with <br>
"allow_failure"<br>
<br>
Alternative: we find a way to manually run downstream pipelines, maybe <br>
not only in dune-common but also in other core modules. Maybe we can run <br>
these jobs automatically if a branch is merged into the master branch. <br>
This is the important situation to test everything, we might not want to <br>
test all downstream modules for each uploaded commit. This needs some <br>
improvement of the gitlab-ci file.<br>
<br>
Best,<br>
Simon<br>
<br>
Am 24.11.22 um 23:36 schrieb Christoph Grüninger:<br>
> Dear Andreas,<br>
> dear Simon,<br>
><br>
> our nightly tests still using Ubuntu 18.04. Currently dune-istl fails, <br>
> probably because a change broke (with full intention) Clang++ 5.0.<br>
> You adjusted the CI images. Can you please have look there, too?<br>
><br>
> One of the failing build pipelines:<br>
> https://gitlab.dune-project.org/infrastructure/dune-nightly-test/-/pipelines/55585
<br>
><br>
><br>
> Bye<br>
> Christoph<br>
><br>
-- <br>
Dr. Simon Praetorius<br>
Technische Universität Dresden<br>
Institute of Scientific Computing<br>
phone: +49 351 463-34432<br>
mail: simon.praetorius@tu-dresden.de<br>
<br>
</div>
</body>
</html>