[dune-functions] [Dune-functions-commit] [Commit] dune-functions - 1201c15: Felix Gruber proposed certain renamings, add this to the TODO

Carsten Gräser graeser at mi.fu-berlin.de
Mon Aug 31 11:01:18 CEST 2015


Am 31.08.2015 um 07:58 schrieb Christian Engwer:
> I'd say
> 
>> +# Misc
>> +* OS: On 21.7.2015, Felix Gruber wrote the following mail to the dune-functions list.
>> +  I think his proposal is worth considering:
>> +
>> +"Currently the classes in dune/functions/functionspacebases/pqknodalbasis.hh are all named with the prefix PQK (capital K), while dune-localfunctions uses the prefix PQk (with lowercase k) in the class names in dune/localfunctions/lagrange/pqkfactory.hh. Also all the Pk and Qk finite element classes are named with a lowercase k.
>> +
>> +I propose to change the class names in pqknodalbasis.hh to make them more consistent with the naming scheme from dune-localfunctions.
>> +This renaming of classes will definitely be an inconvenience for users of dune-functions, but in my opinion this inconvenience will be outweighted by the reduction of inconsistencies to dune-localfunctions which is used by many more people at the moment who might be annoyed at this inconsistency when starting to use dune-functions."
> 
> we just rename this, without deprecation or anything.
> 
> Christian
I support this.

Carsten

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <https://lists.dune-project.org/pipermail/dune-functions/attachments/20150831/1e2b7557/attachment.sig>


More information about the dune-functions mailing list