[dune-pdelab] [dune-pdelab-commit] dune-pdelab r1521 - trunk/dune/pdelab/gridfunctionspace

[Jö Fahlke]

Am Wed, 15. Jun 2011, 17:11:31 +0200 schrieb muething at conan.iwr.uni-heidelberg.de:
> Log:
> [Ordering] Make the orderingPtr() method const for consistency with the ordering() method

Not a good idea.  This change means you now can modify internal data of a
const CompositeGridFunctionSpace.  To illustrate: to make the change really
consistent you would need to write (note the const in the template argument to
shared_ptr)

      const shared_ptr<const Ordering> &orderingPtr() const { return orderingp; }

But that would probably introduce a lot of compilation errors.

> Modified:
>    trunk/dune/pdelab/gridfunctionspace/compositegridfunctionspace.hh
>    trunk/dune/pdelab/gridfunctionspace/gridfunctionspace.hh
>    trunk/dune/pdelab/gridfunctionspace/powergridfunctionspace.hh
> 
> Modified: trunk/dune/pdelab/gridfunctionspace/compositegridfunctionspace.hh
> ==============================================================================
> --- trunk/dune/pdelab/gridfunctionspace/compositegridfunctionspace.hh	Wed Jun 15 17:11:27 2011	(r1520)
> +++ trunk/dune/pdelab/gridfunctionspace/compositegridfunctionspace.hh	Wed Jun 15 17:11:30 2011	(r1521)
> @@ -85,7 +85,7 @@
>        { }
>  
>        const Ordering &ordering() const { return *orderingp; }
> -      const shared_ptr<Ordering> &orderingPtr() { return orderingp; }
> +      const shared_ptr<Ordering> &orderingPtr() const { return orderingp; }

-- 
featured product: Debian GNU/Linux - http://www.debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: Digital signature
URL: <https://lists.dune-project.org/pipermail/dune-pdelab/attachments/20110615/19758fc1/attachment.sig>