[dune-pdelab] Release... to branch or not to branch

[Oliver Sander]

I am getting test suite failures in dune-pdelab.

E.G.: testfemwithgfs (in dune/pdelab/test/fem) fails with compiler error

In file included from ../../../../dune/pdelab/ordering/orderingbase.hh:11:0,
                 from ../../../../dune/pdelab/backend/istl/matrixhelpers.hh:14,
                 from ../../../../dune/pdelab/backend/istl/descriptors.hh:8,
                 from ../../../../dune/pdelab/gridfunctionspace/gridfunctionspace.hh:27,
                 from testfemwithgfs.cc:16:
../../../../dune/pdelab/gridfunctionspace/gridfunctionspacebase.hh:159:35: error: ‘B’ does not name a type
       GridFunctionSpaceBase(const B& backend, const OrderingTag& ordering_tag)
                                   ^
../../../../dune/pdelab/gridfunctionspace/gridfunctionspacebase.hh:159:38: error: ISO C++ forbids declaration of ‘backend’ with no type [-fpermissive]
       GridFunctionSpaceBase(const B& backend, const OrderingTag& ordering_tag)



The corresponding code is

#if HAVE_RVALUE_REFERENCES

      template<typename Backend_, typename OrderingTag_>
      GridFunctionSpaceBase(Backend_&& backend, OrderingTag_&& ordering_tag)
        : _backend(std::forward<Backend_>(backend))
        , _ordering_tag(std::forward<OrderingTag_>(ordering_tag))
      {
        TypeTree::applyToTree(gfs(),impl::reset_root_space_flag());
      }

#else

159 -->      GridFunctionSpaceBase(const B& backend, const OrderingTag& ordering_tag)
        : _backend(backend)
        , _ordering_tag(ordering_tag)
        , _size(0)
        , _global_size(0)
        , _is_root_space(true)
        , _initialized(false)
      {
        TypeTree::applyToTree(gfs(),impl::reset_root_space_flag());
      }

#endif

There are two problems here:
a) HAVE_RVALUE_REFERENCES is not set in config.h even though my
compiler supports it.  Did anybody remove the test?
b) The code in the #else branch really is buggy --> there really is no definition of B


What's the proper fix here?

Cheers,
Oliver


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 534 bytes
Desc: OpenPGP digital signature
URL: <https://lists.dune-project.org/pipermail/dune-pdelab/attachments/20140411/9a385b02/attachment.sig>