[dune-pdelab] Patches

[Christian Engwer]

Hi Oli,

thanks for the heads up, the first patch is appliedn, the second would
break code when using alugrid. Thus we have to wait. This is a general
problem which I'm going to ask about on the list...

Christian

On Wed, Apr 15, 2015 at 04:19:27PM +0200, Oliver Sander wrote:
> Dear pdelab-team,
> please find attached two minor patches that fix a few compiler warnings.
> Thanks for considering,
> Oliver

> From c49f10a050047e748ff0538cf4c05093f987c8db Mon Sep 17 00:00:00 2001
> From: Oliver Sander <sander at igpm.rwth-aachen.de>
> Date: Wed, 15 Apr 2015 16:16:47 +0200
> Subject: [PATCH 1/2] Remove unused local type
> 
> ---
>  dune/pdelab/gridfunctionspace/vtk.hh | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/dune/pdelab/gridfunctionspace/vtk.hh b/dune/pdelab/gridfunctionspace/vtk.hh
> index a2593c0..3ced08c 100644
> --- a/dune/pdelab/gridfunctionspace/vtk.hh
> +++ b/dune/pdelab/gridfunctionspace/vtk.hh
> @@ -613,7 +613,6 @@ namespace Dune {
>          template<typename Factory, typename TreePath>
>          OutputCollector& addVertexFunction(Factory factory, TreePath tp, std::string name)
>          {
> -          typedef typename TypeTree::extract_child_type<typename Data::LFS,TreePath>::type LFS;
>            typedef typename std::remove_reference<decltype(*factory.create(TypeTree::extract_child(_data->_lfs,tp),_data))>::type DGF;
>            _vtk_writer.addVertexData(std::make_shared<VTKGridFunctionAdapter<DGF> >(factory.create(TypeTree::extract_child(_data->_lfs,tp),_data),name));
>            return *this;
> -- 
> 2.1.4
> 

> From dabdd681d9ec75f02cce49ff7fdf539f30b7ad5c Mon Sep 17 00:00:00 2001
> From: Oliver Sander <sander at igpm.rwth-aachen.de>
> Date: Wed, 15 Apr 2015 16:17:15 +0200
> Subject: [PATCH 2/2] Remove some instances where EntityPointers were
>  dereferenced
> 
> These create deprecation warnings.
> ---
>  dune/pdelab/constraints/common/constraints.hh | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/dune/pdelab/constraints/common/constraints.hh b/dune/pdelab/constraints/common/constraints.hh
> index 2eabfcd..a69f748 100644
> --- a/dune/pdelab/constraints/common/constraints.hh
> +++ b/dune/pdelab/constraints/common/constraints.hh
> @@ -612,12 +612,12 @@ namespace Dune {
>  
>              if (iit->neighbor()){
>  
> -              Dune::GeometryType gtn = iit->outside()->type();
> -              const typename GV::IndexSet::IndexType idn = is.index(*(iit->outside()))+gtoffset[gtn];
> +              Dune::GeometryType gtn = iit->outside().type();
> +              const typename GV::IndexSet::IndexType idn = is.index(iit->outside())+gtoffset[gtn];
>  
>                if(id>idn){
>                  // bind local function space to element in neighbor
> -                lfs_f.bind( *(iit->outside()) );
> +                lfs_f.bind( iit->outside() );
>  
>                  CL cl_neighbor;
>  
> -- 
> 2.1.4
> 




> _______________________________________________
> dune-pdelab mailing list
> dune-pdelab at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune-pdelab


-- 
Prof. Dr. Christian Engwer 
Institut für Numerische und Angewandte Mathematik
Fachbereich Mathematik und Informatik der Universität Münster
Einsteinstrasse 62
48149 Münster

E-Mail	christian.engwer at uni-muenster.de
Telefon	+49 251 83-35067
FAX		+49 251 83-32729