<html lang='en'>
<head>
<meta content='text/html; charset=utf-8' http-equiv='Content-Type'>
<title>
GitLab
</title>
</meta>
</head>
<style>
img {
max-width: 100%;
height: auto;
}
p.details {
font-style:italic;
color:#777
}
.footer p {
font-size:small;
color:#777
}
pre.commit-message {
white-space: pre-wrap;
}
.file-stats a {
text-decoration: none;
}
.file-stats .new-file {
color: #090;
}
.file-stats .deleted-file {
color: #B00;
}
</style>
<body>
<div class='content'>
<div>
<p><a href="http://conan2.iwr.uni-heidelberg.de/git/pdelab/dune-pdelab/issues/7" title="Issue: Improve CMake handling of tests" class="gfm gfm-issue">#7</a> and <a href="http://conan2.iwr.uni-heidelberg.de/git/pdelab/dune-pdelab/merge_requests/8" title="Merge Request: Feature/enable all packages and pdelab test macro" class="gfm gfm-merge_request">!8</a> was on that. Sorry if you missed that.</p>
<p>In fact, there is good reasons to avoid the testing magic:</p>
<ul>
<li>ctest is ONLY usable through "make test", which limits it severly</li>
<li>As soon as one test does not compile, you cannot run the test suite</li>
<li>There are some hidden assumptions in the magic: Tests need to reside in directories called "test" etc.</li>
<li>the MAKE_FLAGS on make test issue is handled</li>
<li>the implementation is a mess</li>
</ul>
<p>The new implementation uses (as you proposed in FS1621) a target build_tests, but hides the details through the macro pdelab_add_test introduced in <a href="http://conan2.iwr.uni-heidelberg.de/git/pdelab/dune-pdelab/commit/f2ad0e0aaba6eb9b9f591bd52b13675392b61bb0" title="Commit: Dominic Kempf - [CMake] Introduce a macro pdelab_add_test()" class="gfm gfm-commit">f2ad0e0a</a>.</p>
</div>
</div>
<div class='footer' style='margin-top: 10px;'>
<p>
—
<br>
<a href="http://conan2.iwr.uni-heidelberg.de/git/pdelab/dune-pdelab/merge_requests/48#note_1722">View it on GitLab</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"http://conan2.iwr.uni-heidelberg.de/git/pdelab/dune-pdelab/merge_requests/48#note_1722"}}</script>
You're receiving this notification because you are a member of the PDELab / dune-pdelab project team.
</p>
</div>
</body>
</html>