<html lang='en'>
<head>
<meta content='text/html; charset=utf-8' http-equiv='Content-Type'>
<title>
GitLab
</title>
</meta>
</head>
<style>
img {
max-width: 100%;
height: auto;
}
p.details {
font-style:italic;
color:#777
}
.footer p {
font-size:small;
color:#777
}
pre.commit-message {
white-space: pre-wrap;
}
.file-stats a {
text-decoration: none;
}
.file-stats .new-file {
color: #090;
}
.file-stats .deleted-file {
color: #B00;
}
</style>
<body>
<div class='content'>
<div>
<p>Let me comment on your raised questions:</p>
<ul>
<li>EntitySet:
<ul>
<li>as this is the outcome of our telephone discussion, I'm obviously in favour of this change, but have some smaller comments</li>
<li>did you model the EntitySet similar to dune-functions? We might want follow the interface already now, to have an easy transistion, once 2.4 is out.</li>
<li>I don't like the name AllEntitySet, as it suggests to include also vertices etc. Again, if we keep the naming scheme and API from functions, we can remove our implementation without changing the other code, once functions in a dependency.</li>
</ul>
</li>
<li>the 2.4 behaviour is fine with me.</li>
</ul>
</div>
</div>
<div class='footer' style='margin-top: 10px;'>
<p>
—
<br>
<a href="http://conan2.iwr.uni-heidelberg.de/git/pdelab/dune-pdelab/merge_requests/69#note_2167">View it on GitLab</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"http://conan2.iwr.uni-heidelberg.de/git/pdelab/dune-pdelab/merge_requests/69#note_2167"}}</script>
You're receiving this notification because you are a member of the PDELab / dune-pdelab project team.
</p>
</div>
</body>
</html>