[Dune] GridInterface Remarks.

[Robert Kloefkorn]

Christian Engwer wrote:
> Hi,
> 
> This shouldn't be a problem. The only thing we would have to change is
> GridInterface and GridDefault.
Already check it. It isn't a problem. I'll change that including all the 
grid.

>>Another thing is, that the method leafbegin need a template parameter 
>>PartitionType, just as the lbegin method.
> 
> 
> Agree.
Done.
> 
> 
>>Furthermore, in my opinion, the default lbegin and leafbegin should be 
>>for Interior_Partition and not for All_Partition, because for serial 
>>grid just have an interior which is the same as all partition for them, 
>>but for parallel grids this matters. From my point of view this means 
>>that one always wants to iterate over the interior domain, and thats why 
>>this should be the default type.
> 
> 
> I'm not sure what would be best. But no matter what the default is, it
> is not to likely that a sequential algorithm will do something
> meaningful in parallel.

Thats right, but with All_Partition as default it definitely not not 
working. With Interior_Partition as default I can use my code in serial 
and parallel. That doesn't mean because of that we have to change the 
interface, its just that I think the Interior version makes more sense.
> 
> 
>>As i mentioned before, the mark method should get an Entity and not an 
>>EntityPointer as parameter.
> 
> 
> As I explained you before it is impossible to store or copy Entities
> therefor it is impossible to use Entity as a parameter. What we should
> try to achieve is a way to subclass The different InteratorWrappers
> from the EntityPointer. This would allow us to declare
>   mark(EntityPointer &)
> and still supply Leaf-, Level-, Hierarchic- or IntersectionIterator as
> the parameter.

Ok, that way it sounds better.

Bye

R

-- 

   Robert Klöfkorn           <robertk at mathematik.uni-freiburg.de>

   Mathematisches Institut              Tel: +49 (0) 761 203 5631
   Abt. für Angewandte Mathematik       Fax: +49 (0) 761 203 5632
   Universität Freiburg
   Hermann-Herder-Str. 10
   79104 Freiburg

   http://www.mathematik.uni-freiburg.de/IAM/homepages/robertk