[Dune] [#355] Introduce variable "category" in Dune::Preconditioner (ISTL)

[Dune]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#355 - Introduce variable "category" in Dune::Preconditioner (ISTL)
User who did this - Markus Blatt (mblatt)

----------
Unfortunately category is compile time constant in each subclass of preconditioner ans is therefore not accessible in the base class.

We (or I) introduced it to accomplish compile time checks such that parallel preconditioners are used with parallel scalarproducts, etc. IMHO
this is vital for developers and throwing an exception is not an option for people compiling on supercomputers. Unfortunately these checks only
work if the actual preconditioner (and not the base class) is passed to the solver constructor. I see that this implementation conflicts with the dynamic polymorphismn used in ISTL. 

The dynamic polymorphism and virtual functions were merely used to not trouble users with an additional template parameter of the solver to specify the preconditioner used. IMHO this is not vital and the programming overhead of statically providing the type of the preconditioner is negligable.

Therefore I propose to introduce a template parameter for the preconditioner to the solver classes.

(As workaround just templatize your code and provide the actual implementation of the preconditioner to the solver)
----------

More information can be found at the following URL:
http://conan.informatik.uni-stuttgart.de/flyspray/index.php?do=details&task_id=355#comment412

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.