[Dune] [#333] segfault in SeqOverlappingSchwarz

[Dune]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#333 - segfault in SeqOverlappingSchwarz
User who did this - Markus Blatt (mblatt)

----------
Sombody changed something in the test:

810     mblatt   for(int j=0; j < N; ++j)
   810     mblatt     for(int i=0; i < N; ++i)
   810     mblatt       {
   841    christi         int xdomain = i/domainSize;
   841    christi         int ydomain = j/domainSize;
   841    christi         int mainDomain=ydomain*domainsPerDim+xdomain;
   841    christi         int id=j*N+i;
   841    christi         domains[mainDomain].insert(id);
   841    christi         rowToDomain[id].push_back(mainDomain);
   841    christi         
   841    christi         // check left domain
   841    christi         int domain = (i-overlap)/domainSize;
   841    christi         if(domain>=0 && domain<domainsPerDim)
   841    christi         {
   841    christi           domains[ydomain*domainsPerDim+domain].insert(id);
   841    christi           rowToDomain[id].push_back(ydomain*domainsPerDim+domain);
   841    christi         }
   810     mblatt 
   841    christi         //check right domain
   841    christi         domain = (i+overlap)/domainSize;
   841    christi         if(domain>=0 && domain<domainsPerDim)
   841    christi         {
   841    christi           domains[ydomain*domainsPerDim+domain].insert(id);
   841    christi           rowToDomain[id].push_back(ydomain*domainsPerDim+domain);
   841    christi         }

[...]

which results in this:

 row to domain
row=0: 0 0 0 0 0
row=1: 0 0 0 0 0
row=2: 1 1 1 1 1
row=3: 1 1 1 1 1
row=4: 0 0 0 0 0
row=5: 0 0 0 0 0
row=6: 1 1 1 1 1
row=7: 1 1 1 1 1
row=8: 2 2 2 2 2
row=9: 2 2 2 2 2
row=10: 3 3 3 3 3
row=11: 3 3 3 3 3
row=12: 2 2 2 2 2
row=13: 2 2 2 2 2
row=14: 3 3 3 3 3
row=15: 3 3 3 3 3

Mmh! This mwas probably not intended. At lestt I considered it a mistake andd introduced an assertion to check whether each domain only occures once for each row.

I consider this  a user mistake! One should probably throw an exception here and warn in the documentation.
----------

More information can be found at the following URL:
http://conan.informatik.uni-stuttgart.de/flyspray/index.php?do=details&task_id=333#comment397

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.