[Dune] [#455] tuples.hh uses preprocessor symbols to rename classes

Dune dune at dune-project.org
Mon Nov 10 10:56:58 CET 2008


THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

A new Flyspray task has been opened.  Details are below. 

User who did this - Martin Nolte (nolte) 

Attached to Project - Dune
Summary - tuples.hh uses preprocessor symbols to rename classes
Task Type - Bug Report
Category - Common
Status - New
Assigned To - 
Operating System - Unspecified / All
Severity - Critical
Priority - Normal
Reported Version - SVN
Due in Version - 1.2
Due Date - Undecided
Details - In dune-common/common/tuples.hh preprocessor defines are used to rename new tr1 implementations into the old Dune names:

#define ElementType tuple_element
#define Size tuple_size
#define Tuple tuple

As these names are used locally in other code fragments, too. Bugs resulting from this defines are _very_ hard to track.

Please think twice before using the preprocessor. It causes trouble to others!

I already fixed ElementType, which was the cause of my trouble (Yes, I should simply have reverted the change)

More information can be found at the following URL:
http://www.dune-project.org/flyspray/index.php?do=details&task_id=455

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.




More information about the Dune mailing list