[Dune] [#645] Review and apply ArrayList patch

Dune dune at dune-project.org
Thu Dec 3 19:01:19 CET 2009


THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#645 - Review and apply ArrayList patch
User who did this - Markus Blatt (mblatt)

----------
I think it frees the memory of shared_ptr but not the object it points to.

You are right. these leaks are due to the change in rev. 5503 and that was before the shared_ptr change. Previously the object was allocated on the stack. Now the empty constructor allocates an object on the heap.
Is this conforming to the standard? I guess not.
Consequently, std::shared_ptr will not delete the object pointed as it is allocated outside of the class. (but that is just another guess...)

Adjusting ArrayList to the std::shared_ptr seems to rather hard to me. If you agree I would rather incorporated the old behaviour into ArrayList directly and skip using shared_ptr.


----------

More information can be found at the following URL:
http://www.dune-project.org/flyspray/index.php?do=details&task_id=645#comment1447

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.




More information about the Dune mailing list