[Dune] [#682] Minor bug in use of shared_ptr<> in mpicollectivecommunicationhh

Dune dune at dune-project.org
Fri Dec 4 22:26:01 CET 2009


THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#682 - Minor bug in use of shared_ptr<> in mpicollectivecommunicationhh
User who did this - Atgeirr Flø Rasmussen (atgeirr)

----------
First, I must apologize for not realizing that the Dune-supplied shared_ptr<> replacement does not supply get() or the conversion-to-bool-equivalent (which as far as I have understood usually is done as a pointer-to-member-function to avoid unwanted conversions succeeding).

In any case, the use of operator->() for obtaining the pointer is not usable with the non-Dune variants, so something must be added. I suggest adding get() and reset(T*) to the Dune-supplied shared_ptr<> so that they can be used in Dune code without portability issues. Then using if (ptr.get()) should be a portable way to check for a non-null pointer.
----------

More information can be found at the following URL:
http://www.dune-project.org/flyspray/index.php?do=details&task_id=682#comment1454

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.




More information about the Dune mailing list