[Dune] [Dune-Commit] dune-grid r4845 - releases/1.2/grid/common

[Oliver Sander]

Hi Martin!
The changes you propose are fine with me.  I admit I'd forgotten about 
the #warning.
The problem about marking the begin/end methods deprecated is that 
marking member
templates deprecated does not work in any gcc I have seen.

--
Oliver

Martin Nolte schrieb:
> Hi Oliver,
>
> I don't know if this change really is clever. Now you _always_ get a 
> warning about using deprecated code. I don't know if the source of the 
> warning is sufficiently obvious. Moreover it is quite annoying (unless 
> you switch warnings off).
>
> I would suggest that we do one of the following solutions:
> a) Make the warning more meaningful and tell the user how to switch it 
> off.
> b) Remove the warning and mark _all_ begin / end methods on the index 
> sets deprecated.
>
> Cheers,
>
> Martin
>
> sander at dune-project.org wrote:
>> Author: sander
>> Date: 2009-02-13 16:08:15 +0100 (Fri, 13 Feb 2009)
>> New Revision: 4845
>>
>> Modified:
>>    releases/1.2/grid/common/indexidset.hh
>> Log:
>> Enable IndexSets to provide iterators.  Since this feature is not 
>> deprecated in 1.1 it needs to be in 1.2 (deprecating mark is there, 
>> but not working)
>>
>> Modified: releases/1.2/grid/common/indexidset.hh
>> ===================================================================
>> --- releases/1.2/grid/common/indexidset.hh    2009-02-13 14:29:49 UTC 
>> (rev 4844)
>> +++ releases/1.2/grid/common/indexidset.hh    2009-02-13 15:08:15 UTC 
>> (rev 4845)
>> @@ -11,7 +11,7 @@
>>  
>>  #include <dune/grid/common/grid.hh>
>>  
>> -//#define INDEXSET_HAS_ITERATORS
>> +#define INDEXSET_HAS_ITERATORS
>>  /** @file
>>      @author Peter Bastian
>>      @brief Provides base classes for index and id sets
>>
>>
>> _______________________________________________
>> Dune-Commit mailing list
>> Dune-Commit at dune-project.org
>> http://lists.dune-project.org/mailman/listinfo/dune-commit
>


-- 
************************************************************************
* Oliver Sander                ** email: sander at mi.fu-berlin.de        *
* Freie Universität Berlin     ** phone: + 49 (30) 838 75348           *
* Institut für Mathematik      ** URL  : page.mi.fu-berlin.de/~sander  *
* Arnimallee 6                 ** -------------------------------------*
* 14195 Berlin, Germany        ** Member of MATHEON (www.matheon.de)   *
************************************************************************