[Dune] [Dune-Commit] dune-grid r5959 - trunk/dune/grid/common/test

[Andreas Dedner]

 > I am afraid just out-commenting the problematic lines is not a long-
 > term solution :-)
Its reduces the time of 'make check' on my computer
by about 20min - ok I just learned about the compiler
switch -Wfatal-errors available with gcc > 3.5.
With that it is not a problem but still
a message "does not work for d>3 see FS 482"
would have been more informing and would have saved me time
finding out what the problem is.

In general I think we should discuss what the
idea of the check and test target in the Makefile.am shoul be.
In my opinion a test which is known
to fail and for which we have a FS could be removed from the
check target in the Makefile.am. One make check on all
core modules took me 1.5h - that is not
something I would care to do, for testing a change in some
implementation. One reason was the ALUGrid check and some things in the
GenericLocalFunctions and I am working on that. But overall a lot of 
output is generated and it really takes ages...
Andreas


Oliver Sander wrote:
> It never compiled.  That's FS 482.  It put the extra lines there to document
> that the quadrature rules are not as dimension-independent as the rest of
> Dune.  I'am afraid just out-commenting the problematic lines is not a long-
> term solution :-)
> 
> best,
> Oliver
> 
> dedner at dune-project.org schrieb:
>> Author: dedner
>> Date: 2009-11-19 15:43:28 +0100 (Thu, 19 Nov 2009)
>> New Revision: 5959
>>
>> Modified:
>>    trunk/dune/grid/common/test/test-quadrature.cc
>> Log:
>> d>3 quadrature do not work because factory needs to instantiate SimplexQuadrature<d> as well as CubeQuadrature<d> - how could this test have ever compiled\?
>>
>> Modified: trunk/dune/grid/common/test/test-quadrature.cc
>> ===================================================================
>> --- trunk/dune/grid/common/test/test-quadrature.cc	2009-11-19 14:07:51 UTC (rev 5958)
>> +++ trunk/dune/grid/common/test/test-quadrature.cc	2009-11-19 14:43:28 UTC (rev 5959)
>> @@ -196,9 +196,9 @@
>>      Dune::GeometryType cube1d(Dune::GeometryType::cube,1);
>>      Dune::GeometryType cube2d(Dune::GeometryType::cube,2);
>>      Dune::GeometryType cube3d(Dune::GeometryType::cube,3);
>> -    Dune::GeometryType cube4d(Dune::GeometryType::cube,4);
>> -    Dune::GeometryType cube5d(Dune::GeometryType::cube,5);
>> -    Dune::GeometryType cube6d(Dune::GeometryType::cube,6);
>> +    // Dune::GeometryType cube4d(Dune::GeometryType::cube,4);
>> +    // Dune::GeometryType cube5d(Dune::GeometryType::cube,5);
>> +    // Dune::GeometryType cube6d(Dune::GeometryType::cube,6);
>>      
>>      Dune::GeometryType simplex0d(Dune::GeometryType::simplex,0);
>>      Dune::GeometryType simplex1d(Dune::GeometryType::simplex,1);
>> @@ -212,9 +212,9 @@
>>      checkWeights<double, 1>(cube1d);
>>      checkWeights<double, 2>(cube2d);
>>      checkWeights<double, 3>(cube3d);
>> -    checkWeights<double, 4>(cube4d);
>> -    checkWeights<double, 5>(cube5d);
>> -    checkWeights<double, 6>(cube6d);
>> +    // checkWeights<double, 4>(cube4d);
>> +    // checkWeights<double, 5>(cube5d);
>> +    // checkWeights<double, 6>(cube6d);
>>  
>>      checkWeights<double, 0>(simplex0d);
>>      checkWeights<double, 1>(simplex1d);
>> @@ -228,9 +228,9 @@
>>      checkQuadrature<double, 1>(cube1d);
>>      checkQuadrature<double, 2>(cube2d);
>>      checkQuadrature<double, 3>(cube3d);
>> -    checkQuadrature<double, 4>(cube4d);
>> -    checkQuadrature<double, 5>(cube5d);
>> -    checkQuadrature<double, 6>(cube6d);
>> +    // checkQuadrature<double, 4>(cube4d);
>> +    // checkQuadrature<double, 5>(cube5d);
>> +    // checkQuadrature<double, 6>(cube6d);
>>  
>>      checkQuadrature<double, 0>(simplex0d);
>>      checkQuadrature<double, 1>(simplex1d);
>>
>>
>> _______________________________________________
>> Dune-Commit mailing list
>> Dune-Commit at dune-project.org
>> http://lists.dune-project.org/mailman/listinfo/dune-commit
>>   
> 
>