[Dune] [Dune-Commit] dune-localfunctions r198 - trunk/dune/finiteelements/common

Oliver Sander sander at mi.fu-berlin.de
Sun Sep 6 22:38:16 CEST 2009


You are perfectly right. As I said, I hadn't seen the 'public'.  Reverting.

--
Oliver

Andreas Dedner schrieb:
> Hi.
> We are also already using parts of the localfuncttions module (for 
> example the LocalKey class)
> and I think that this module is so far developed that, we should not 
> change the interface
> anymore without a short discussion.
> Andreas
>
> Sven Marnach wrote:
>   
>> Hi Oliver,
>>
>> sander at dune-project.org schrieb am So, 06. Sep 2009, um 22:00:49 +0200:
>>   
>>     
>>> [...] instead of inheriting privately from a 3-tuple.
>>>     
>>>       
>>   
>>     
>>> -  class LocalKey : public Dune::tuple<unsigned int, unsigned int, unsigned int>
>>> +  class LocalKey
>>>     
>>>       
>> it wasn't derived privately.  You introduced an interface change with
>> this commit, which might be relevant to PDELab.  Before, LocalKeys
>> could be compared and sorted lexicographically, which is not possible
>> any more.  I will look into this tomorrow.
>>
>> Regards,
>>     Sven
>>
>> _______________________________________________
>> Dune mailing list
>> Dune at dune-project.org
>> http://lists.dune-project.org/mailman/listinfo/dune
>>   
>>     
>
>
> _______________________________________________
> Dune mailing list
> Dune at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune
>   


-- 
************************************************************************
* Oliver Sander                ** email: sander at mi.fu-berlin.de        *
* Freie Universität Berlin     ** phone: + 49 (30) 838 75348           *
* Institut für Mathematik      ** URL  : page.mi.fu-berlin.de/~sander  *
* Arnimallee 6                 ** -------------------------------------*
* 14195 Berlin, Germany        ** Member of MATHEON (www.matheon.de)   *
************************************************************************





More information about the Dune mailing list