[Dune] [#599] dune-common does not recognize MVAPICH2

[Steffen Müthing]

Thank you for fixing this, Christian!

Unfortunately, there is still a minor problem. I tried reopening the  
issue in FlySpray,
but only got an SQL command thrown back at me. So I'll just post on  
the list:

You probably tested this with the current version of MVAPICH2, version  
1.4.
That version defines the macro MVAPICH2_VERSION, but MVAPICH2 1.2,
which is installed here in Stuttgart, defines MVAPICH_VERSION (not  
very intuitive,
but that's the way it is...). I checked the sources of MVAPICH1 1.1,  
and there is no
MVAPICH_VERSION macro there either (they still use the MPICH_VERSION  
macro),
so the presence of MVAPICH_VERSION is a clear indicator for MVAPICH2  
1.2.

The following patch made the detection work with MVAPICH2 1.2:

diff --git a/m4/mpi-config.m4 b/m4/mpi-config.m4
index c436bbc..bad1c23 100644
--- a/m4/mpi-config.m4
+++ b/m4/mpi-config.m4
@@ -215,6 +215,16 @@ test_mvapich2() {
  #define _OSU_MVAPICH_
  #include <mpi.h>
  #include <stdio.h>
+
+/* MVAPICH2_VERSION is only defined for MVAPICH2 1.4+
+ * MVAPICH_VERSION is only defined for MVAPICH2 1.2.*
+ * We can thus fall back to MVAPICH_VERSION if MVAPICH2_VERSION
+ * is not defined.
+ */
+#ifndef MVAPICH2_VERSION
+#define MVAPICH2_VERSION MVAPICH_VERSION
+#endif
+
  int main() { printf("%s\n",MVAPICH2_VERSION); return 0; }
  _EOF

Again, thank you for fixing this so quickly!

Steffen


Am 23.09.2009 um 11:09 schrieb Dune:

> THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
>
> The following task is now closed:
>
> FS#599 - dune-common does not recognize MVAPICH2
> User who did this - Christian Engwer (christi)
>
> Reason for closing: Fixed
> More information can be found at the following URL:
> http://www.dune-project.org/flyspray/index.php?do=details&task_id=599
>
> You are receiving this message because you have requested it from  
> the Flyspray bugtracking system.  If you did not expect this message  
> or don't want to receive mails in future, you can change your  
> notification settings at the URL shown above.
>
> _______________________________________________
> Dune mailing list
> Dune at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune