[Dune] [Dune-Commit] dune-grid r6593 - releases/2.0/dune/grid/albertagrid/test

Christian Engwer christi at uni-hd.de
Fri Apr 9 10:31:40 CEST 2010


Hi Martin,

I just changed the return value of the "expected failure". The
programe states that there was an expected failure, but returns
true. This contradicts the XFAIL semantics.

Christian

On Fri, Apr 09, 2010 at 07:43:56AM +0200, Martin Nolte wrote:
> Hi Christian,
> 
> I think the test was to demonstrate that AlbertaGrid< 3 > may die
> during refinement even for quite simple grids. I changed the
> heuristics a bit (I actually don't know if that's in the release)
> and since then the test no longer fails. So, instead of making the
> test fail we should expect it to pass?
> 
> Martin
> 
> On 04/08/2010 11:21 PM, christi at dune-project.org wrote:
> >Author: christi
> >Date: 2010-04-08 23:21:03 +0200 (Thu, 08 Apr 2010)
> >New Revision: 6593
> >
> >Modified:
> >    releases/2.0/dune/grid/albertagrid/test/test-alberta3d-refine.cc
> >Log:
> >the test is expected to fail... so make it fail
> >
> >
> >Modified: releases/2.0/dune/grid/albertagrid/test/test-alberta3d-refine.cc
> >===================================================================
> >--- releases/2.0/dune/grid/albertagrid/test/test-alberta3d-refine.cc	2010-04-08 21:13:35 UTC (rev 6592)
> >+++ releases/2.0/dune/grid/albertagrid/test/test-alberta3d-refine.cc	2010-04-08 21:21:03 UTC (rev 6593)
> >@@ -78,7 +78,7 @@
> >        Dune::shared_ptr<Grid>  grid = TriangulatedUnitCubeMaker<Grid>::create();
> >        grid->globalRefine(2);
> >
> >-      result = 0;
> >+      result = 1;
> >      }
> >  #endif
> >
> >
> >
> >_______________________________________________
> >Dune-Commit mailing list
> >Dune-Commit at dune-project.org
> >http://lists.dune-project.org/mailman/listinfo/dune-commit
> 



More information about the Dune mailing list