[Dune] Dune gridtype patch für 2.0

Oliver Sander sander at mi.fu-berlin.de
Mon Apr 12 17:19:23 CEST 2010


I have an uneasy feeling about this one too.  For my taste, it adds a bit
too much magic.  Even worse, it adds decentral magic.  But I admit
that this is a subjective judgement.

best,
Oliver

Christian Engwer schrieb:
> Hi Robert,
>
>   
>> dieser Patch sollte noch zum dune-grid release 2.0 hinzugefügt
>> werden aus Kompatibilitätsgründen.
>>     
>
> I didn't like this patch from it's beginning and think it still needs
> discussion. I will not merge this patch to the release. It is a
> significant change.
>
> Christian
>
>   
>> Index: m4/dune_gridtype.m4
>> ===================================================================
>> --- m4/dune_gridtype.m4	(revision 0)
>> +++ m4/dune_gridtype.m4	(revision 0)
>> @@ -0,0 +1,31 @@
>> +# DUNE_OUTPUT_GRIDTYPE
>> +# 
>> +# Writes out 'gridtype.hh' and 'dgfgridtype.hh' for the project.
>> +#
>> +# If a project intends to use this magic, its configure.ac should contain a
>> +# call to this macro (somewhere around AC_OUTPUT)
>> +AC_DEFUN([DUNE_OUTPUT_GRIDTYPE],[
>> +  GRIDTYPE_HH="gridtype.hh"
>> +  AC_MSG_NOTICE([creating $GRIDTYPE_HH])
>> +
>> +  cat > $GRIDTYPE_HH << EOF
>> +// Warning: Do not edit this file. It is generated automatically by the
>> +//          module's configure script.
>> +//
>> +// If you want to edit the contents of this file, have a look at
>> +// 'dune-grid/m4/dune_gridtype.m4'.
>> +#include <dune/grid/utility/gridtype.hh> 
>> +EOF
>> +
>> +  DGFGRIDTYPE_HH="dgfgridtype.hh"
>> +  AC_MSG_NOTICE([creating $DGFGRIDTYPE_HH])
>> +
>> +  cat > $DGFGRIDTYPE_HH << EOF
>> +// Warning: Do not edit this file. It is generated automatically by the
>> +//          module's configure script.
>> +//
>> +// If you want to edit the contents of this file, have a look at
>> +// 'dune-grid/m4/dune_gridtype.m4'.
>> +#include <dune/grid/io/file/dgfparser/dgfgridtype.hh>
>> +EOF
>> +])
>> Index: m4/Makefile.am
>> ===================================================================
>> --- m4/Makefile.am	(revision 6600)
>> +++ m4/Makefile.am	(working copy)
>> @@ -1,6 +1,6 @@
>>  # $Id: Makefile.am 5184 2008-04-27 17:37:27Z christi $
>>  
>> -ALLM4S = dune_grid.m4 dune_griddim.m4 alberta.m4 alglib.m4 alugrid.m4 ug.m4 amiramesh.m4 grape.m4 psurface.m4 enable-old-numbering.m4
>> +ALLM4S = dune_grid.m4 dune_griddim.m4 dune_gridtype.m4 alberta.m4 alglib.m4 alugrid.m4 ug.m4 amiramesh.m4 grape.m4 psurface.m4 enable-old-numbering.m4
>>  
>>  aclocaldir = $(datadir)/aclocal
>>  aclocal_DATA = $(ALLM4S)
>> Index: configure.ac
>> ===================================================================
>> --- configure.ac	(revision 6600)
>> +++ configure.ac	(working copy)
>> @@ -77,3 +77,4 @@
>>      m4/Makefile
>>      dune-grid.pc])
>>  AC_OUTPUT
>> +DUNE_OUTPUT_GRIDTYPE
>>     
>
>
> _______________________________________________
> Dune mailing list
> Dune at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune
>   


-- 
************************************************************************
* Oliver Sander                ** email: sander at mi.fu-berlin.de        *
* Freie Universität Berlin     ** phone: + 49 (30) 838 75348           *
* Institut für Mathematik      ** URL  : page.mi.fu-berlin.de/~sander  *
* Arnimallee 6                 ** -------------------------------------*
* 14195 Berlin, Germany        ** Member of MATHEON (www.matheon.de)   *
************************************************************************




More information about the Dune mailing list