[Dune] [#771] configure generated gridtype.hh / dgfgridtype.hh

[Dune]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#771 - configure generated gridtype.hh / dgfgridtype.hh
User who did this - Christian Engwer (christi)

----------
First, I understand the goal, I just don't like the solution.

I still consider the current approach a hack, as it introduces preprocessor magic. After the last changes, even more magic was introduced. The main reason why I rejected the request for merge was, that it isn't working. There are many places in the trunk, where the is not working anymore, like the grid-howto (at least that was the state 3 weeks ago). If I tried to fix the code an followed the instructions in the doxygen-documentation, it still failed, it seems the docs are (or were) a bit outdated.

You were right. The change is a compatibility issue... and that is the reason that is not part of the release.

Now to the current solution...
- Up to now the hack was limited to small part of the repository. It was always agreed that it isn't part of the interface. But now after the latest changes all implementations have to provide their own part of the magic.
- There are certain things which are not possible with the current approach, especially it is not possible to define different grids.
- I do like the idea of easy exchangeable grids, but I get the impression that this hack starts growing in complexity and when a hack is getting mroe complex, it requires reconsideration... perhaps there is a better solution to the problem.
- I'd like to have solution, where you can easily change the grid but not by means of preprocessor magic. Perhaps it is possible to introduce this switch on the C++ level and thus allow different ways of changing the grid.

Up to now I don't have a better solution, but we need think about one.
You imply that your changes and the centralization are an improvement. That is exactly what I doubt.

Christian

PS: no need to shout.

----------

More information can be found at the following URL:
http://www.dune-project.org/flyspray/index.php?do=details&task_id=771#comment1890

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.