[Dune] [Dune-Commit] dune-grid r6391 - trunk/m4

Oliver Sander sander at mi.fu-berlin.de
Wed Mar 10 16:14:34 CET 2010


Hi Martin!
Isn't this change something we should discuss and vote upon?
I am not saying that it is bad, but I would like to have time to think
about it and object.  My first impression is that while creating
gridtype.hh headers from m4 may(!) by a reasonable thing to,
creating dgf-specific stuff is evil and I'd rather not have it.

Also, please don't insert lines like the one below without a
comment line.

best,
Oliver

>
> Modified: trunk/m4/ug.m4
> ===================================================================
> --- trunk/m4/ug.m4	2010-03-10 10:45:52 UTC (rev 6390)
> +++ trunk/m4/ug.m4	2010-03-10 14:59:33 UTC (rev 6391)
> @@ -215,6 +215,7 @@
>    DUNE_ADD_ALL_PKG([UG], [\${UG_CPPFLAGS}], [\${UG_LDFLAGS}], [\${UG_LIBS}])
>  
>    if test x$HAVE_UG = x1 ; then
> +      DUNE_DEFINE_GRIDTYPE([UGGRID],[GRIDDIM == WORLDDIM],[Dune::UGGrid< dimgrid >],[dune/grid/uggrid.hh],[dune/grid/io/file/dgfparser/dgfug.hh])
>        AC_DEFINE(HAVE_UG, ENABLE_UG, 
>          [This is only true if UG was found by configure 
>           _and_ if the application uses the UG_CPPFLAGS])
>
>
> _______________________________________________
> Dune-Commit mailing list
> Dune-Commit at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune-commit
>   


-- 
************************************************************************
* Oliver Sander                ** email: sander at mi.fu-berlin.de        *
* Freie Universität Berlin     ** phone: + 49 (30) 838 75348           *
* Institut für Mathematik      ** URL  : page.mi.fu-berlin.de/~sander  *
* Arnimallee 6                 ** -------------------------------------*
* 14195 Berlin, Germany        ** Member of MATHEON (www.matheon.de)   *
************************************************************************





More information about the Dune mailing list