[Dune] [#764] Allow user to override ALUGrid library directory

[Dune]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#764 - Allow user to override ALUGrid library directory
User who did this - Jö Fahlke (joe)

----------
Your patch is good.  If you want to make it perfect, there are some small
improvements possible:

 * You introduce a variable ac_alugrid_lib_path.  First the ac_ namespace is
   better left to autoconf.  Second, AC_ARG_WITH implicitly introduces the
   variable with_alugrid_libdir, which does exactly the same thing.  If you
   use that instead, everyone familiar with autoconf will immediately know the
   value was given on the command line.

 * You should check whether the value is "no" and treat it equally to "".
   This allows to explicitly say --without-alugrid-libdir (which is the same
   as --with-alugrid-libdir=no).

 * You should not check whether the directory exists if the value is "no" or
   "", so people an explicitly say "use default".

If you don't have time or otherwise don't want to incorporate these changes,
I'm happy to apply the current version.  Of course, I'd like a perfect version
better :)

----------

More information can be found at the following URL:
http://www.dune-project.org/flyspray/index.php?do=details&task_id=764#comment1845

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.