[Dune] [Dune-Commit] dune-grid r7138 - trunk/dune/grid/uggrid

[Christian Engwer]

On Sat, Nov 27, 2010 at 01:32:19PM +0100, Martin Nolte wrote:
> Shouldn't these translation methods be deprecated for the 2.1 release? The
> reference elements they correspond to are gone.

The implications are not 100% clear, e.g. yaspgrid & sgrid rely
internally on the old numbering, but in principal I agree. We want to
get rid of the old numbering.

I'll look into yasp- & sgrid.

Christian

> On 11/27/2010 12:05 AM, graeser at dune-project.org wrote:
> > Author: graeser
> > Date: 2010-11-27 00:05:39 +0100 (Sat, 27 Nov 2010)
> > New Revision: 7138
> > 
> > Modified:
> >    trunk/dune/grid/uggrid/uggridentity.hh
> >    trunk/dune/grid/uggrid/uggridintersections.hh
> > Log:
> > Index translation still takes the TopologyId
> > 
> > 
> > Modified: trunk/dune/grid/uggrid/uggridentity.hh
> > ===================================================================
> > --- trunk/dune/grid/uggrid/uggridentity.hh	2010-11-26 22:56:24 UTC (rev 7137)
> > +++ trunk/dune/grid/uggrid/uggridentity.hh	2010-11-26 23:05:39 UTC (rev 7138)
> > @@ -281,7 +281,7 @@
> >      typename GridImp::template Codim< codim >::EntityPointer subEntity ( int i ) const
> >      {
> >        typedef GenericGeometry::MapNumberingProvider< GridImp::dimension > Numbering;
> > -      const int j = Numbering::template generic2dune< codim >( type(), i );
> > +      const int j = Numbering::template generic2dune< codim >( type().id(), i );
> >        return entity< codim >( j );
> >      }
> >  
> > 
> > Modified: trunk/dune/grid/uggrid/uggridintersections.hh
> > ===================================================================
> > --- trunk/dune/grid/uggrid/uggridintersections.hh	2010-11-26 22:56:24 UTC (rev 7137)
> > +++ trunk/dune/grid/uggrid/uggridintersections.hh	2010-11-26 23:05:39 UTC (rev 7138)
> > @@ -123,7 +123,7 @@
> >    {
> >      const int number = UGGridRenumberer<dim>::facesUGtoDUNE(neighborCount_, UG_NS<dimworld>::Sides_Of_Elem(center_));
> >      typedef GenericGeometry::MapNumberingProvider< dim > Numbering;
> > -    return Numbering::template dune2generic< 1 >( inside()->type(), number );
> > +    return Numbering::template dune2generic< 1 >( inside()->type().id(), number );
> >    }
> >  
> >    //! local index of codim 1 entity in neighbor where intersection is contained
> > @@ -353,7 +353,7 @@
> >      const int number = UGGridRenumberer<dim>::facesUGtoDUNE(neighborCount_, UG_NS<dimworld>::Sides_Of_Elem(center_));
> >  
> >      typedef GenericGeometry::MapNumberingProvider< dim > Numbering;
> > -    return Numbering::template dune2generic< 1 >( inside()->type(), number );
> > +    return Numbering::template dune2generic< 1 >( inside()->type().id(), number );
> >    }
> >  
> >    //! local index of codim 1 entity in neighbor where intersection is contained
> > 
> > 
> > _______________________________________________
> > Dune-Commit mailing list
> > Dune-Commit at dune-project.org
> > http://lists.dune-project.org/mailman/listinfo/dune-commit
> 
> -- 
> Martin Nolte <nolte at mathematik.uni-freiburg.de>
> 
> Universität Freiburg                                   phone: +49-761-203-5642
> Abteilung für angewandte Mathematik                    fax:   +49-761-203-5632
> Hermann-Herder-Straße 10
> 79104 Freiburg, Germany
> 
> _______________________________________________
> Dune mailing list
> Dune at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune
>