[Dune] unused header dune/grid/genericgeometry/referencemappings.hh
Martin Nolte
nolte at mathematik.uni-freiburg.de
Sun Nov 28 14:04:08 CET 2010
As far as I remember (it's already getting dark around every detail in that
code), the class is now historical.
When starting on the generic stuff, there was no generic reference element
(and it was not decided upon its introduction). Still, access to the reference
mappings was desirable, so I simply implemented them.
Even after the introduction of the generic reference element, it was not
possible to get the reference mapping for an arbitrary "topologyId". It is
only possible after the most recent changes in the
GenericReferenceElementContainer. That's why the class is still used in
dune-localfunctions.
That said, I guess we use the generic reference element in dune-localfunctions
and silently remove referencemappings.hh. Of course, this will have to be
checked very carefully.
Best,
Martin
On 11/28/2010 01:46 PM, Christian Engwer wrote:
> On Sun, Nov 28, 2010 at 12:30:43AM +0100, Jö Fahlke wrote:
>> Am Sat, 27. Nov 2010, 22:18:00 +0100 schrieb Jö Fahlke:
>>> dune/grid/genericgeometry/referencemappings.hh does not appear in and #include
>>> line anywhere in dune-grid and not covered in the tests. Also, it is
>>> completely undocumented, so I have trouble finding out what it might be useful
>>> for.
>>>
>>> Can this class be either removed or documented? It it is to be removes, was
>>> it ever part of an official interface, i.e. should we deprecate it first?
>>>
>>> It uses Int2Type, and since it isn't used anywhere I know I can't even do
>>> rudimentary checks whether it still works after a transition, so I'll leave it
>>> alone for now.
>>
>> Nevermind, it _is_ used in dune-localfunctions and checked in the tests.
>
> but what is the difference between referencemapping anf
> referenceelement?
>
> puzzeled
> Christian
>
> _______________________________________________
> Dune mailing list
> Dune at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune
--
Martin Nolte <nolte at mathematik.uni-freiburg.de>
Universität Freiburg phone: +49-761-203-5630
Abteilung für angewandte Mathematik fax: +49-761-203-5632
Hermann-Herder-Straße 10
79104 Freiburg, Germany
More information about the Dune
mailing list