[Dune] [Dune-Commit] dune-common r6279 - trunk/dune/common

[Andreas Dedner]

Hi Oliver.

I think deprecating a method should involve removing its usage in any
dune core module.
Especially in a case like this where an obvious substitution for this
method is not available.
We decided to deprecate this method under the assumption that it was not
used anymore -
as far as I remember.somebody checked the core modules and stated that it
was not used - this was wrong information.

If you are afraid that this issue will be forgotten than we can open a
flyspray task.

Best
Andreas

On 30/11/10 10:55, Oliver Sander wrote:
> Hi Andreas!
> The method basicType() is deprecated, hence the DUNE_DEPRECATED
> attribute should be in the code.  If the warnings bother you then you
> are free to remove it in your local copy, but I would want to keep it in
> the repository.  Otherwise we will just forget about it.  So please
> revert
> your patch.
>
> Best,
> Oliver
>
> Am 30.11.2010 00:33, schrieb dedner at dune-project.org:
>> Author: dedner
>> Date: 2010-11-30 00:33:34 +0100 (Tue, 30 Nov 2010)
>> New Revision: 6279
>>
>> Modified:
>>     trunk/dune/common/geometrytype.hh
>> Log:
>> let us deprecated this when it is really not used anymore
>>
>> Modified: trunk/dune/common/geometrytype.hh
>> ===================================================================
>> --- trunk/dune/common/geometrytype.hh    2010-11-29 12:06:01 UTC (rev
>> 6278)
>> +++ trunk/dune/common/geometrytype.hh    2010-11-29 23:33:34 UTC (rev
>> 6279)
>> @@ -243,7 +243,7 @@
>>           }
>>
>>           /** \brief Return the basic type of the type */
>> -        BasicType basicType() const DUNE_DEPRECATED {
>> +        BasicType basicType() const {
>>               if (isSimplex())
>>                   return GeometryType::simplex;
>>               if (isCube())
>>
>>
>> _______________________________________________
>> Dune-Commit mailing list
>> Dune-Commit at dune-project.org
>> http://lists.dune-project.org/mailman/listinfo/dune-commit
>>    
>
>