[Dune] [Dune-Commit] dune-common r6429 - trunk/dune/common/test

[Markus Blatt]

Hi,

I implemeted this a long time ago and therefore I might be wrong. But
isn't this test supposed to work even without MPI?

CollectiveCommunication should have a specialization for the fake
MPICommunicator. IF not, this should be a bug.

Regards,

Markus

On Wed, Apr 27, 2011 at 09:07:38PM +0200, christi at dune-project.org wrote:
> Author: christi
> Date: 2011-04-27 21:07:37 +0200 (Wed, 27 Apr 2011)
> New Revision: 6429
> 
> Modified:
>    trunk/dune/common/test/mpicollectivecommunication.cc
> Log:
> mark test "mpicollectivecommunication" as skipped if MPI is not available
> 
> Modified: trunk/dune/common/test/mpicollectivecommunication.cc
> ===================================================================
> --- trunk/dune/common/test/mpicollectivecommunication.cc	2011-04-27 19:07:24 UTC (rev 6428)
> +++ trunk/dune/common/test/mpicollectivecommunication.cc	2011-04-27 19:07:37 UTC (rev 6429)
> @@ -12,13 +12,11 @@
>  int main(int argc, char** argv)
>  {
>    typedef Dune::MPIHelper Helper;
> -  typedef Helper::MPICommunicator MPIComm;
> +  Helper& mpi = Helper::instance(argc, argv);
>    
>  #if HAVE_MPI 
>    {
> -    Helper& mpi = Helper::instance(argc, argv);
> -    
> -    
> +    typedef Helper::MPICommunicator MPIComm;
>      Dune::CollectiveCommunication<MPIComm> comm(mpi.getCommunicator());
>  
>      enum { length = 5 };
> @@ -50,6 +48,7 @@
>    std::cout << "We are at the end!"<<std::endl;
>  #else 
>    std::cout << "WARNING: test Dune::CollectiveCommunication<MPI_Comm> disabled because MPI not available! " << std::endl;
> +  return 77;
>  #endif
>    return 0;
>  }
> 
> 
> _______________________________________________
> Dune-Commit mailing list
> Dune-Commit at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune-commit
> 

-- 
Markus Blatt, Interdisciplinary Center for Scientific Computing,
University Heidelberg, Im Neuenheimer Feld 368, D-69120 Heidelberg

'Mathematics knows no races or geographic boundaries; for
mathematics, the cultural world is one country' - David Hilbert